Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/IVYPORTAL-18147-Adding-new-dashboard-dialogs-with-templates-store… #1322

Merged
merged 3 commits into from
Dec 19, 2024
Merged

bug/IVYPORTAL-18147-Adding-new-dashboard-dialogs-with-templates-store… #1322

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
926dec3
bug/IVYPORTAL-18147-Adding-new-dashboard-dialogs-with-templates-store…
lmluat-axonivy Dec 18, 2024
642cef6
bug/IVYPORTAL-18147-Adding-new-dashboard-dialogs-with-templates-store…
lmluat-axonivy Dec 19, 2024
55a87f0
bug/IVYPORTAL-18147-Adding-new-dashboard-dialogs-with-templates-store…
lmluat-axonivy Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...IvyPortal/portal/src/ch/ivy/addon/portal/generic/bean/DashboardTemplateSelectionBean.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import java.io.Serializable;
import java.util.ArrayList;
import java.util.Collections;

import javax.faces.bean.ManagedBean;
import javax.faces.bean.ViewScoped;
Expand Down Expand Up @@ -46,6 +47,7 @@ private void onAddDashboard(boolean isPublicDashboard) {

private void mappingCommonDataToNewDashboard(String templateId, String dashboardId) {
this.selectedDashboard.setTemplateId(templateId);
this.selectedDashboard.setPermissionDTOs(Collections.emptyList());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to new ArrayList<>() instead.

Reason: Returns an empty list (immutable). This list is serializable.

this.selectedDashboard.setId(dashboardId);
this.selectedDashboard.setTitles(new ArrayList<>());
this.selectedDashboard.setIcon(this.isPublicDashboard ? PUBLIC_DASHBOARD_DEFAULT_ICON : PRIVATE_DASHBOARD_DEFAULT_ICON);
Expand Down
Loading