-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug/IVYPORTAL-18051-Portal-Dashboard-shows-no-permission-screen-when-… #1280
Merged
nhthinh-axonivy
merged 7 commits into
master
from
bug/IVYPORTAL-18051-Portal-Dashboard-shows-no-permission-screen-when-dashboards-is-empty
Dec 12, 2024
Merged
bug/IVYPORTAL-18051-Portal-Dashboard-shows-no-permission-screen-when-… #1280
nhthinh-axonivy
merged 7 commits into
master
from
bug/IVYPORTAL-18051-Portal-Dashboard-shows-no-permission-screen-when-dashboards-is-empty
Dec 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dashboards-is-empty _ adapt logic _ import default dashboard
…o bug/IVYPORTAL-18051-Portal-Dashboard-shows-no-permission-screen-when-dashboards-is-empty
…en-when-dashboards-is-empty" This reverts commit 2d4c740.
…o bug/IVYPORTAL-18051-Portal-Dashboard-shows-no-permission-screen-when-dashboards-is-empty
…dashboards-is-empty
…dashboards-is-empty
…dashboards-is-empty
lmluat-axonivy
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
nhthinh-axonivy
deleted the
bug/IVYPORTAL-18051-Portal-Dashboard-shows-no-permission-screen-when-dashboards-is-empty
branch
December 12, 2024 02:45
lmluat-axonivy
added a commit
that referenced
this pull request
Dec 18, 2024
* feature/IVYPORTAL-18032-UI-facelift-conflict - Add border in Actions menu of Task widget * feature/IVYPORTAL-18032-UI-facelift-conflict - Add border in actions menu for case widget * bug/IVYPORTAL-18051-Portal-Dashboard-shows-no-permission-screen-when-… (#1280) * bug/IVYPORTAL-18051-Portal-Dashboard-shows-no-permission-screen-when-dashboards-is-empty _ adapt logic _ import default dashboard * feature/IVYPORTAL-18032-UI-facelift-conflict - Update Edit external link UI * feature/IVYPORTAL-18032-UI-facelift-conflict - Add error message when uploading file fail * IVYPORTAL-18072 SPIKE: Evaluate the full screen issue with new case and task list - Implemented * feature/IVYPORTAL-18032-UI-facelift-conflict - Update link and button following guidelines * feature/IVYPORTAL-18032-UI-facelift-conflict - Update UI of delete button * feature/IVYPORTAL-18032-UI-facelift-conflict - Update UI of remove/delete button * feature/IVYPORTAL-18032-UI-facelift-conflict - Change icon of action menu * feature/IVYPORTAL-18032-UI-facelift-conflict - Update jenkinsfile * feature/IVYPORTAL-18032-UI-facelift-conflict - Update jenkins file * feature/IVYPORTAL-18032-UI-facelift-conflict - Update UI of destroy button in CaseItemDetails and TaskItemDetails * feature/IVYPORTAL-18032-UI-facelift-conflict - Update height of upload image in external link * feature/IVYPORTAL-18032-UI-facelift-conflict - Update GUI tests * feature/IVYPORTAL-18032-UI-facelift-conflict - Update screenshot tests * feature/IVYPORTAL-18028-High-Failure-to-use-HTTPS-or-SFTP-URL-in-Maven-artifact-upload-download-Two-occurrences (#1298) - Use HTTPS URL in maven artifact download * Update portal_walkthrough_testplan.jmx for new test data (#1306) * IVYPORTAL-18029 High - Client-side cross-site scripting - Fixed security check * Updated all pom build.plugin.version=12.0.0, ivy.engine.version=12.0.2 (#1308) Co-authored-by: wawa-axonivy <[email protected]> * IVYPORTAL-18029 High - Client-side cross-site scripting - Try to fix Client-side cross-site scripting * feature/IVYPORTAL-18032-UI-facelift-conflict - Update UI delete document button * feature/IVYPORTAL-18032-UI-facelift-conflict - Upload document-screenshot.js file * feature/IVYPORTAL-18032-UI-facelift-conflict - Update screenshot test * feature/IVYPORTAL-18032-UI-facelift-conflict - Update reset filter in task widget filter * IVYPORTAL-18029 High - Client-side cross-site scripting - Apply new approach * feature/IVYPORTAL-18032-UI-facelift-conflict - Update document * feature/IVYPORTAL-18032-UI-facelift-conflict - Update screenshot tests * Revert "feature/IVYPORTAL-18032-UI-facelift-conflict" This reverts commit 0f4b154. * Revert "feature/IVYPORTAL-18032-UI-facelift-conflict" This reverts commit 3c38c31. * feature/IVYPORTAL-18032-UI-facelift-conflict - Update UI of process image * IVYPORTAL-18029: Security findings- Client-side cross-site scripting (#1310) * feature/IVYPORTAL-18028-High-Failure-to-use-HTTPS-or-SFTP-URL-in-Maven-artifact-upload-download-Two-occurrences-12 (#1305) * IVYPORTAL-18029 High - Client-side cross-site scripting - Apply new approach to load taskUrl from server * IVYPORTAL-18031 Medium - DOM text reinterpreted as HTML - Implement * IVYPORTAL-18029 Security findings- Client-side cross-site scripting - Fixed GUI test * IVYPORTAL-18072 SPIKE: Evaluate the full screen issue with new case and task list - Handled feedback: make the dashboard load from memory responsiveness * feature/IVYPORTAL-18032-UI-facelift-conflict - Handle feedback --------- Co-authored-by: Thinh Nguyen <[email protected]> Co-authored-by: mnhnam-axonivy <[email protected]> Co-authored-by: Tung Le <[email protected]> Co-authored-by: wawa-axonivy <[email protected]> Co-authored-by: Nam Mai <[email protected]> Co-authored-by: Nam.Chu <[email protected]> Co-authored-by: Nam Chu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…dashboards-is-empty
_ adapt logic
_ import default dashboard