bug/IVYPORTAL-17918-BUG-Notification-bug-some-lines-have-no-message-a…

…nd-cause-error-when-clicking-Start
axonivy-market · Nov 22, 2024 · 674e2e8 · 674e2e8
1 parent 9cd40f4
commit 674e2e8
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 18 deletions.
diff --git a/...ortal/src_hd/com/axonivy/portal/component/NotificationFullPage/NotificationFullPage.xhtml b/...ortal/src_hd/com/axonivy/portal/component/NotificationFullPage/NotificationFullPage.xhtml
@@ -50,14 +50,19 @@
                         <p:tooltip for="notification-mark-as-read"
                           value="#{ivy.cms.co('/ch.ivy.addon.portalkit.ui.jsf/notifications/markAsRead')}" />
                       </div>
-                      <div class="flex notification-message-block flex-column">
-                        <p:commandLink id="notification-message" styleClass="notification-message"
-                          actionListener="#{notificationBean.goToTaskDetail(notification)}" rendered="#{notification.infoAction != null}">
-                        </p:commandLink>
-                        <h:outputText value="#{htmlSanitizerBean.sanitize(notification.message)}" />
-                        <p:tooltip for="notification-message" value="#{notification.infoAction.title}" />
-                        <h:outputText value="#{notification.timeSince}" styleClass="font-normal notifications-item-time-since" />
-                      </div>
+                       <div class="flex notification-message-block flex-column">
+                         <h:panelGroup rendered="#{notification.infoAction != null}">
+                           <p:commandLink id="notification-message" styleClass="notification-message"
+                              actionListener="#{notificationBean.goToNotificationDetail(notification, isWorkingOnATask, task)}">
+                              <h:outputText value="#{htmlSanitizerBean.sanitize(notification.message)}" />
+                           </p:commandLink>
+                           <p:tooltip for="notification-message" value="#{notification.infoAction.title}" />
+                         </h:panelGroup>
+                         <h:panelGroup rendered="#{notification.infoAction == null}">
+                            <h:outputText value="#{htmlSanitizerBean.sanitize(notification.message)}" />
+                         </h:panelGroup>
+                         <h:outputText value="#{notification.timeSince}" styleClass="font-normal notifications-item-time-since" />
+                       </div>
                        <p:outputPanel rendered="#{notificationBean.isActionAvailible(notification)}" styleClass="flex notification-action-block">
                         <p:commandLink id="notification-start-task" styleClass="notification-start-task"
                           actionListener="#{notificationBean.startTask(notification)}" rendered="#{notification.runAction != null}">

diff --git a/...src_hd/com/axonivy/portal/dashboard/component/NotificationWidget/NotificationWidget.xhtml b/...src_hd/com/axonivy/portal/dashboard/component/NotificationWidget/NotificationWidget.xhtml
@@ -70,12 +70,17 @@
                       value="#{ivy.cms.co('/ch.ivy.addon.portalkit.ui.jsf/notifications/markAsRead')}" />
                   </div>
                   <div class="flex notification-message-block flex-column">
-                      <p:commandLink id="notification-message" styleClass="notification-message" actionListener="#{widget.goToTaskDetail(notification)}"
-                         rendered="#{notification.infoAction != null}" disabled="#{!isReadOnlyMode}" >
+                    <h:panelGroup rendered="#{notification.infoAction != null}">
+                      <p:commandLink id="notification-message"
+                        styleClass="notification-message"
+                        actionListener="#{notificationBean.goToNotificationDetail(notification, isWorkingOnATask, task)}">
+                        <h:outputText value="#{htmlSanitizerBean.sanitize(notification.message)}" />
                       </p:commandLink>
+                      <p:tooltip for="notification-message" value="#{notification.infoAction.title}" />
+                    </h:panelGroup>
+                    <h:panelGroup rendered="#{notification.infoAction == null}">
                       <h:outputText value="#{htmlSanitizerBean.sanitize(notification.message)}" />
-                      <p:tooltip for="notification-message" value="#{notification.infoAction.title}" /> 
-                    <p:tooltip for="notification-message" value="#{notification.infoAction.title}" />
+                    </h:panelGroup>
                     <h:outputText value="#{notification.timeSince}" styleClass="font-normal notifications-item-time-since" />
                   </div>
                   <p:outputPanel rendered="#{notificationBean.isActionAvailible(notification)}" styleClass="flex notification-action-block">

diff --git a/AxonIvyPortal/portal/webContent/layouts/includes/notification.xhtml b/AxonIvyPortal/portal/webContent/layouts/includes/notification.xhtml
@@ -84,13 +84,17 @@
                               value="#{ivy.cms.co('/ch.ivy.addon.portalkit.ui.jsf/notifications/markAsRead')}" />
                           </div>
                           <div class="flex notification-message-block flex-column">
-                            <p:commandLink id="notification-message" styleClass="notification-message"
-                              actionListener="#{notificationBean.goToNotificationDetail(notification, isWorkingOnATask, task)}"
-                              rendered="#{notification.infoAction != null}">
-                            </p:commandLink>
-                            <h:outputText value="#{htmlSanitizerBean.sanitize(notification.message)}" />
+                            <h:panelGroup rendered="#{notification.infoAction != null}">
+                              <p:commandLink id="notification-message" styleClass="notification-message"
+                                actionListener="#{notificationBean.goToNotificationDetail(notification, isWorkingOnATask, task)}">
+                                <h:outputText value="#{htmlSanitizerBean.sanitize(notification.message)}" />
+                              </p:commandLink>
                             <p:tooltip for="notification-message" value="#{notification.infoAction.title}" />
-                            <h:outputText value="#{notification.timeSince}" styleClass="font-normal notifications-item-time-since" />
+                           </h:panelGroup>
+                           <h:panelGroup rendered="#{notification.infoAction == null}">
+                             <h:outputText value="#{htmlSanitizerBean.sanitize(notification.message)}" />
+                           </h:panelGroup>
+                           <h:outputText value="#{notification.timeSince}" styleClass="font-normal notifications-item-time-since" />
                           </div>
                           <p:outputPanel rendered="#{notificationBean.isActionAvailible(notification)}" styleClass="flex notification-action-block">
                             <p:commandLink id="notification-start-task"