Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init document for open weather connector #8

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Conversation

ndkhanh-axonivy
Copy link
Collaborator

No description provided.

Copy link
Contributor

github-actions bot commented Mar 15, 2024

Test Results

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 1c4c9d7. ± Comparison against base commit 69dd7e4.

♻️ This comment has been updated with latest results.

@ndkhanh-axonivy
Copy link
Collaborator Author

Hi @andreasbalsiger I created this pull request for the documentation step.
Could you help review this README.md file, it describes the purposes and functionality for the OpenWeather connector.
Thanks!

Copy link

@andreasbalsiger andreasbalsiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please adapt my edits accordingly.

open-weather-connector-product/README.md Outdated Show resolved Hide resolved
open-weather-connector-product/README.md Outdated Show resolved Hide resolved
open-weather-connector-product/README.md Outdated Show resolved Hide resolved
open-weather-connector-product/README.md Outdated Show resolved Hide resolved
open-weather-connector-product/README.md Outdated Show resolved Hide resolved
open-weather-connector-product/README.md Outdated Show resolved Hide resolved
open-weather-connector-product/README.md Outdated Show resolved Hide resolved
open-weather-connector-product/README.md Outdated Show resolved Hide resolved
open-weather-connector-product/README.md Outdated Show resolved Hide resolved
open-weather-connector-product/README.md Outdated Show resolved Hide resolved
@ndkhanh-axonivy
Copy link
Collaborator Author

Hi @andreasbalsiger , I've just pushed a new commit that addresses the feedback you provided. Could you please review the updated README again?

Thanks for taking a look at the document!

Copy link

@andreasbalsiger andreasbalsiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks... I can approve the changes.

@ndkhanh-axonivy ndkhanh-axonivy merged commit b79d333 into master Mar 18, 2024
1 of 4 checks passed
@ndkhanh-axonivy ndkhanh-axonivy deleted the feature/document branch March 18, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants