Onboard Open Weather Connector to Axon-ivy market #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
ghost
reviewed
Feb 27, 2024
| return weatherDescription; | ||
| } | ||
|
|
||
| private static int getWeatherPriority(int weatherId) { |
There was a problem hiding this comment.
This function should be part of class rather than instance. It look like helper or util, but I don't want to create a class just contains only function so... I put it here
There was a problem hiding this comment.
I mean remove static keyword. Use regular functions instead of static functions
There was a problem hiding this comment.
I understand what you mean, but I think this function should be static because it seems more class method than instance method.
...ather-connector-demo/src/com/axonivy/connector/openweather/dto/DailyForecastDisplayInfo.java
Outdated
Show resolved
Hide resolved
...-test/src_test/com/axonivy/connector/openweather/test/AbstractOpenWeatherMapProcessTest.java
Outdated
Show resolved
Hide resolved
...-connector-test/src_test/com/axonivy/connector/openweather/test/AirPollutionProcessTest.java
Outdated
Show resolved
Hide resolved
...ector-test/src_test/com/axonivy/connector/openweather/test/GeocodingLocationProcessTest.java
Outdated
Show resolved
Hide resolved
ghost
reviewed
Mar 12, 2024
| return weatherDescription; | ||
| } | ||
|
|
||
| private static int getWeatherPriority(int weatherId) { |
There was a problem hiding this comment.
I mean remove static keyword. Use regular functions instead of static functions
| @@ -0,0 +1,4 @@ | |||
| Variables: | |||
There was a problem hiding this comment.
Leave this file empty, the demo should use the same variables as the connector.
There was a problem hiding this comment.
I also add the defaultSearchedCity to the demo variable. Is any problems if the demo different than connector?
...er-connector-demo/src/com/axonivy/connector/openweather/managedbean/ForecastWeatherBean.java
Outdated
Show resolved
Hide resolved
...er-connector-demo/src/com/axonivy/connector/openweather/managedbean/ForecastWeatherBean.java
Outdated
Show resolved
Hide resolved
...er-connector-demo/src/com/axonivy/connector/openweather/managedbean/ForecastWeatherBean.java
Outdated
Show resolved
Hide resolved
ghost
removed a link to an issue
15 tasks
ghost
approved these changes
Mar 14, 2024
| public static final String DEFAULT_SEARCHED_CITY_VARIABLE_PATH = "openWeatherConnectorDemo_defaultSearchedCity"; | ||
| public static final String SELECTED_TIME_INDEX_JS_VARIABLE_NAME = "selectedTimeIndex"; | ||
|
|
||
| private Constants() { |
There was a problem hiding this comment.
You can remove this constructor by change Constants to interface
ndkhanh-axonivy
added a commit
that referenced
this pull request
Mar 18, 2024
* Onboard Open Weather Connector to Axon-ivy market (#2) * Initial commit * product-name * Initial project setup * Init project * Update chart listener * Update pom * Fill real data to UI * Update forecast weather * Add action for UI * Update panChart * Refactor code * refactor html * Update new chart pop * update converter feature * Refactor * Enhance UI * Update feature pan chart when first time switch to another tab * remove unused comment * Add AuthFeature and update README.md * Update README.md * Remove Product project sample * Update variable file * Update precipitation chart * Update test process for weather geo * Update unit test for ivy process * Reformat process UI * Rename formatted to postfix name * Remove appId value in demo project * Update groupId in product project * Update README with how to get api key * Refactor variable name * Remove hard string and update cms * Add dark theme * Update dark mode theme * Remove unused function * Delete unused images * Update README.md * Delete open-weather-connector-product/images/forecast-sub-process.png * Handle feedbacks * Fix unit test errors * Handle feedbacks * Add custom for Units --------- Co-authored-by: khanhduynguyen170900 <[email protected]> * Update latest ivy-environment same as project version (#5) * Update general path for test process (#6) * Update README.md --------- Co-authored-by: khanhduynguyen170900 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.