Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MARP-1548 Suspicious installation counts #257

Merged

Conversation

quanpham-axonivy
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the enhancement New feature or request label Dec 13, 2024
@quanpham-axonivy quanpham-axonivy force-pushed the feature/marp-1548-suspicious-installation-count branch 2 times, most recently from bd3ee9e to cc64d49 Compare December 16, 2024 07:16
@quanpham-axonivy quanpham-axonivy force-pushed the feature/marp-1548-suspicious-installation-count branch from 7c5e713 to 995f8b6 Compare December 16, 2024 07:21
Copy link
Contributor

@phhung-axonivy phhung-axonivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comments.
You need to think about the action builds after this PR is merged to develop.
You introduced a new property MARKET_LOG_PATH but you don't change anything that is related the action builds.

@quanpham-axonivy quanpham-axonivy force-pushed the feature/marp-1548-suspicious-installation-count branch from 46c9534 to a5044c9 Compare December 16, 2024 09:34
@quanpham-axonivy quanpham-axonivy force-pushed the feature/marp-1548-suspicious-installation-count branch from a5044c9 to 935ed8b Compare December 17, 2024 08:33
Copy link
Contributor

@phhung-axonivy phhung-axonivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@quanpham-axonivy quanpham-axonivy merged commit e1a0d85 into develop Dec 17, 2024
9 checks passed
@quanpham-axonivy quanpham-axonivy deleted the feature/marp-1548-suspicious-installation-count branch December 17, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants