-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MARP-1548 Suspicious installation counts #257
MARP-1548 Suspicious installation counts #257
Conversation
bd3ee9e
to
cc64d49
Compare
7c5e713
to
995f8b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check my comments.
You need to think about the action builds after this PR is merged to develop.
You introduced a new property MARKET_LOG_PATH but you don't change anything that is related the action builds.
marketplace-service/src/main/java/com/axonivy/market/util/LoggingUtils.java
Outdated
Show resolved
Hide resolved
marketplace-service/src/main/java/com/axonivy/market/util/LoggingUtils.java
Outdated
Show resolved
Hide resolved
marketplace-service/src/test/java/com/axonivy/market/util/FileUtilsTest.java
Show resolved
Hide resolved
marketplace-service/src/main/java/com/axonivy/market/util/LoggingUtils.java
Outdated
Show resolved
Hide resolved
marketplace-service/src/main/java/com/axonivy/market/logging/LoggableAspect.java
Outdated
Show resolved
Hide resolved
marketplace-service/src/main/java/com/axonivy/market/logging/LoggableAspect.java
Outdated
Show resolved
Hide resolved
marketplace-service/src/main/java/com/axonivy/market/logging/LoggableAspect.java
Outdated
Show resolved
Hide resolved
marketplace-service/src/main/java/com/axonivy/market/logging/LoggableAspect.java
Outdated
Show resolved
Hide resolved
46c9534
to
a5044c9
Compare
marketplace-service/src/test/java/com/axonivy/market/util/LoggingUtilsTest.java
Outdated
Show resolved
Hide resolved
marketplace-service/src/main/java/com/axonivy/market/logging/LoggableAspect.java
Show resolved
Hide resolved
a5044c9
to
935ed8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.