MARP-1014: Product detail tabs #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-not-hidden # Conflicts: # marketplace-ui/src/app/modules/product/product-detail/product-detail.component.spec.ts # marketplace-ui/src/app/modules/product/product-detail/product-detail.component.ts
…s-not-hidden # Conflicts: # marketplace-ui/src/app/modules/product/product-detail/product-detail.component.spec.ts # marketplace-ui/src/app/modules/product/product-detail/product-detail.component.ts
-Refined display product module content logic (for null, undefined content based on Languge) -Refactor html of each content tab (using @for)
…s-not-hidden # Conflicts: # marketplace-ui/src/app/modules/product/product-detail/product-detail.component.html
-Refined how tabs are displayed on PC and mobile. -Add productId to ProductModuleContent interface in corresponding to Backend.
…s-not-hidden # Conflicts: # marketplace-ui/src/app/modules/product/product-detail/product-detail.component.spec.ts
-Add product hint name. -Caching issue had been fixed in MARP-989. -Maven dependency markdown code is no longer red. -Add border for Maven dependency just like the original Market website.
# Conflicts: # marketplace-ui/src/app/modules/product/product-detail/product-detail.component.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Add product hint name.
-Caching issue: No longer memorize the active tab of previously closed product.
-Maven dependency markdown code is no longer red.
-Add border for Maven dependency just like the original Market website.
-Edit corresponding test.