MARP-1059 market website rating does not work after login #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es-not-work-after-login
…es-not-work-after-login
…es-not-work-after-login
phhung-axonivy
requested changes
Sep 16, 2024
| } catch (Exception e) { | ||
| return new ResponseEntity<>(Map.of(e.getClass().getName(), e.getMessage()), HttpStatus.BAD_REQUEST); | ||
| return new ResponseEntity<>(Map.of(CommonConstants.MESSAGE, e.getMessage()), HttpStatus.BAD_REQUEST); | ||
| } | ||
|
|
||
| User user = gitHubService.getAndUpdateUser(accessToken); |
There was a problem hiding this comment.
move this block code to try {}
| @@ -110,7 +111,8 @@ public GitHubAccessTokenResponse getAccessToken(String code, GitHubProperty gitH | |||
| GitHubAccessTokenResponse response = responseEntity.getBody(); | |||
|
|
|||
| if (response != null && response.getError() != null && !response.getError().isBlank()) { | |||
| throw new Oauth2ExchangeCodeException(response.getError(), response.getErrorDescription()); | |||
| String errorDescription = buildErrorDescription(response.getErrorDescription(), gitHubProperty.getOauth2ClientId()); | |||
There was a problem hiding this comment.
We should write a log and not throw exception with this info.
| @@ -110,7 +111,8 @@ public GitHubAccessTokenResponse getAccessToken(String code, GitHubProperty gitH | |||
| GitHubAccessTokenResponse response = responseEntity.getBody(); | |||
|
|
|||
| if (response != null && response.getError() != null && !response.getError().isBlank()) { | |||
| throw new Oauth2ExchangeCodeException(response.getError(), response.getErrorDescription()); | |||
| String errorDescription = buildErrorDescription(response.getErrorDescription(), gitHubProperty.getOauth2ClientId()); | |||
| throw new Oauth2ExchangeCodeException(response.getError(), errorDescription); | |||
There was a problem hiding this comment.
We should write a test for this Exception with ExceptionHandlers.
ndkhanh-axonivy
deleted the
bugfix/MARP-1059-Market-website-Rating-does-not-work-after-login
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.