MARP-989: Empty product detail tabs not hidden #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvtphuc-axonivy
requested changes
Aug 28, 2024
| description: content.description !== null, | ||
| demo: content.demo !== null, | ||
| setup: content.setup !== null , | ||
| description: !this.isPropertyNullOrAllEmpty(content.description), |
There was a problem hiding this comment.
The issue was not fixed in case of the language of description is empty String
There was a problem hiding this comment.
Fixed as commented
| private isPropertyNullOrAllEmpty(property: DisplayValue | null) { | ||
| if (property === null) { | ||
| return true; | ||
| } else { |
There was a problem hiding this comment.
please remove line 182 and 185.
The else here is redundant. if property === null . you already return true
There was a problem hiding this comment.
Fixed as commented
marketplace-ui/src/app/modules/product/product-detail/product-detail.component.ts
Outdated
Show resolved
Hide resolved
…s-not-hidden # Conflicts: # marketplace-ui/src/app/modules/product/product-detail/product-detail.component.spec.ts # marketplace-ui/src/app/modules/product/product-detail/product-detail.component.ts
tvtphuc-axonivy
requested changes
Sep 6, 2024
marketplace-ui/src/app/modules/product/product-detail/product-detail.component.html
Outdated
Show resolved
Hide resolved
marketplace-ui/src/app/modules/product/product-detail/product-detail.component.spec.ts
Outdated
Show resolved
Hide resolved
…s-not-hidden # Conflicts: # marketplace-ui/src/app/modules/product/product-detail/product-detail.component.spec.ts # marketplace-ui/src/app/modules/product/product-detail/product-detail.component.ts
-Refined display product module content logic (for null, undefined content based on Languge) -Refactor html of each content tab (using @for)
…s-not-hidden # Conflicts: # marketplace-ui/src/app/modules/product/product-detail/product-detail.component.html
-Refined how tabs are displayed on PC and mobile. -Add productId to ProductModuleContent interface in corresponding to Backend.
…s-not-hidden # Conflicts: # marketplace-ui/src/app/modules/product/product-detail/product-detail.component.spec.ts
vhhoang-axonivy
deleted the
feature/MARP-989-Empty-product-detail-tabs-not-hidden
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.