-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/marp 760 open marketplace from within designer install item #117
Merged
tvtphuc-axonivy
merged 40 commits into
develop
from
feature/MARP-760-Open-Marketplace-from-within-Designer-install-item
Aug 30, 2024
Merged
Feature/marp 760 open marketplace from within designer install item #117
tvtphuc-axonivy
merged 40 commits into
develop
from
feature/MARP-760-Open-Marketplace-from-within-Designer-install-item
Aug 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thin-Designer-install-item
ntqdinh-axonivy
requested changes
Aug 30, 2024
marketplace-ui/src/app/shared/components/common-dropdown/common-dropdown.component.ts
Outdated
Show resolved
Hide resolved
marketplace-ui/src/app/shared/components/common-dropdown/common-dropdown.component.html
Outdated
Show resolved
Hide resolved
marketplace-service/src/main/java/com/axonivy/market/service/impl/VersionServiceImpl.java
Outdated
Show resolved
Hide resolved
…thin-Designer-install-item
ntqdinh-axonivy
requested changes
Aug 30, 2024
marketplace-service/src/main/java/com/axonivy/market/assembler/ProductDetailModelAssembler.java
Show resolved
Hide resolved
...ct/product-detail/product-detail-version-action/product-detail-version-action.component.html
Outdated
Show resolved
Hide resolved
...duct/product-detail/product-detail-version-action/product-detail-version-action.component.ts
Outdated
Show resolved
Hide resolved
marketplace-ui/src/app/modules/product/product-detail/product-detail.component.ts
Outdated
Show resolved
Hide resolved
ntqdinh-axonivy
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tvtphuc-axonivy
deleted the
feature/MARP-760-Open-Marketplace-from-within-Designer-install-item
branch
August 30, 2024 06:53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.