Fix Sonar issue

axonivy-market · Jul 29, 2024 · e9e7a42 · e9e7a42
1 parent c1e3ac7
commit e9e7a42
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/marketplace-service/src/main/java/com/axonivy/market/constants/RequestParamConstants.java b/marketplace-service/src/main/java/com/axonivy/market/constants/RequestParamConstants.java
@@ -1,5 +1,9 @@
 package com.axonivy.market.constants;
 
+import lombok.AccessLevel;
+import lombok.NoArgsConstructor;
+
+@NoArgsConstructor(access = AccessLevel.PRIVATE)
 public class RequestParamConstants {
   public static final String ID = "id";
   public static final String KEY = "key";

diff --git a/marketplace-service/src/main/java/com/axonivy/market/controller/OAuth2Controller.java b/marketplace-service/src/main/java/com/axonivy/market/controller/OAuth2Controller.java
@@ -49,13 +49,11 @@ public ResponseEntity<Map<String, String>> gitHubLogin(@RequestBody Oauth2Author
           gitHubProperty);
       accessToken = tokenResponse.getAccessToken();
     } catch (Exception e) {
-      return new ResponseEntity<Map<String, String>>(Map.of(e.getClass().getName(), e.getMessage()),
-          HttpStatus.BAD_REQUEST);
+      return new ResponseEntity<>(Map.of(e.getClass().getName(), e.getMessage()), HttpStatus.BAD_REQUEST);
     }
 
     User user = gitHubService.getAndUpdateUser(accessToken);
     String jwtToken = jwtService.generateToken(user);
-    return new ResponseEntity<Map<String, String>>(Collections.singletonMap(GitHubConstants.Json.TOKEN, jwtToken),
-        HttpStatus.OK);
+    return new ResponseEntity<>(Collections.singletonMap(GitHubConstants.Json.TOKEN, jwtToken), HttpStatus.OK);
   }
 }