MARP-760 Handle Sonar

axonivy-market · Aug 30, 2024 · c9ea382 · c9ea382
1 parent 2d08f4e
commit c9ea382
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 12 deletions.
diff --git a/...place-service/src/main/java/com/axonivy/market/assembler/ProductDetailModelAssembler.java b/...place-service/src/main/java/com/axonivy/market/assembler/ProductDetailModelAssembler.java
@@ -5,7 +5,6 @@
 import com.axonivy.market.entity.Product;
 import com.axonivy.market.model.ProductDetailModel;
 import com.axonivy.market.util.VersionUtils;
-import com.fasterxml.jackson.core.JsonProcessingException;
 import lombok.extern.log4j.Log4j2;
 import org.apache.commons.lang3.StringUtils;
 import org.springframework.hateoas.Link;

diff --git a/...etplace-service/src/main/java/com/axonivy/market/controller/ProductDetailsController.java b/...etplace-service/src/main/java/com/axonivy/market/controller/ProductDetailsController.java
@@ -17,7 +17,6 @@
 import java.util.Map;
 
 import com.axonivy.market.model.VersionAndUrlModel;
-import com.fasterxml.jackson.core.JsonProcessingException;
 import io.swagger.v3.oas.annotations.Parameter;
 import io.swagger.v3.oas.annotations.enums.ParameterIn;
 import io.swagger.v3.oas.annotations.tags.Tag;
@@ -108,8 +107,7 @@ public ResponseEntity<Map<String, Object>> findProductJsonContent(@PathVariable(
 
   @GetMapping(VERSIONS_IN_DESIGNER)
   @Operation(summary = "Get the list of released version in product", description = "Collect the released versions in product for ivy designer")
-  public ResponseEntity<List<VersionAndUrlModel>> findVersionsForDesigner(@PathVariable(ID) String id)
-      throws JsonProcessingException {
+  public ResponseEntity<List<VersionAndUrlModel>> findVersionsForDesigner(@PathVariable(ID) String id) {
     List<VersionAndUrlModel> versionList = versionService.getVersionsForDesigner(id);
     return new ResponseEntity<>(versionList, HttpStatus.OK);
   }

diff --git a/marketplace-service/src/main/java/com/axonivy/market/service/VersionService.java b/marketplace-service/src/main/java/com/axonivy/market/service/VersionService.java
@@ -2,7 +2,6 @@
 
 import com.axonivy.market.model.MavenArtifactVersionModel;
 import com.axonivy.market.model.VersionAndUrlModel;
-import com.fasterxml.jackson.core.JsonProcessingException;
 import java.util.List;
 import java.util.Map;
 
@@ -17,5 +16,5 @@ List<MavenArtifactVersionModel> getArtifactsAndVersionToDisplay(String productId
 
   Map<String, Object> getProductJsonContentByIdAndVersion(String name , String version);
 
-  List<VersionAndUrlModel> getVersionsForDesigner(String productId) throws JsonProcessingException;
+  List<VersionAndUrlModel> getVersionsForDesigner(String productId);
 }
diff --git a/marketplace-service/src/main/java/com/axonivy/market/service/impl/VersionServiceImpl.java b/marketplace-service/src/main/java/com/axonivy/market/service/impl/VersionServiceImpl.java
@@ -130,7 +130,7 @@ public Map<String, Object> getProductJsonContentByIdAndVersion(String productId,
   }
 
   @Override
-  public List<VersionAndUrlModel> getVersionsForDesigner(String productId) throws JsonProcessingException {
+  public List<VersionAndUrlModel> getVersionsForDesigner(String productId) {
     List<VersionAndUrlModel> versionAndUrlList = new ArrayList<>();
     List<String> versions = productRepository.getReleasedVersionsById(productId);
     for (String version : versions) {

diff --git a/...ace-service/src/test/java/com/axonivy/market/controller/ProductDetailsControllerTest.java b/...ace-service/src/test/java/com/axonivy/market/controller/ProductDetailsControllerTest.java
@@ -14,7 +14,6 @@
 import com.axonivy.market.constants.RequestMappingConstants;
 import com.axonivy.market.entity.productjsonfilecontent.ProductJsonContent;
 import com.axonivy.market.model.VersionAndUrlModel;
-import com.fasterxml.jackson.core.JsonProcessingException;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.Test;
@@ -125,7 +124,7 @@ void testSyncInstallationCount() {
   }
 
   @Test
-  void findProductVersionsById() throws JsonProcessingException {
+  void findProductVersionsById() {
     when(versionService.getVersionsForDesigner("google-maps-connector")).thenReturn(mockVersionAndUrlModels());
 
     var result = productDetailsController.findVersionsForDesigner("google-maps-connector");

diff --git a/...etplace-service/src/test/java/com/axonivy/market/service/impl/VersionServiceImplTest.java b/...etplace-service/src/test/java/com/axonivy/market/service/impl/VersionServiceImplTest.java
@@ -14,7 +14,6 @@
 import com.axonivy.market.repository.ProductJsonContentRepository;
 import com.axonivy.market.repository.ProductRepository;
 import com.axonivy.market.util.XmlReaderUtils;
-import com.fasterxml.jackson.core.JsonProcessingException;
 import org.apache.commons.lang3.StringUtils;
 import org.assertj.core.api.Fail;
 import org.junit.jupiter.api.Assertions;
@@ -420,7 +419,7 @@ void testGetRepoNameFromMarketRepo() {
   }
 
   @Test
-  void testGetVersionsForDesigner() throws JsonProcessingException {
+  void testGetVersionsForDesigner() {
     Mockito.when(productRepository.getReleasedVersionsById(anyString()))
         .thenReturn(List.of("11.3.0", "11.1.1", "11.1.0", "10.0.2"));
 
@@ -436,7 +435,7 @@ void testGetVersionsForDesigner() throws JsonProcessingException {
   }
 
   @Test
-  void testGetProductJsonContentByIdAndVersion() throws JsonProcessingException {
+  void testGetProductJsonContentByIdAndVersion() {
     ProductJsonContent mockProductJsonContent = new ProductJsonContent();
     String mockContent = """
         {