handle sonnar

axonivy-market · Dec 17, 2024 · 9b9c237 · 9b9c237
1 parent 69457a3
commit 9b9c237
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 7 deletions.
diff --git a/marketplace-ui/src/app/modules/product/product-detail/product-detail.component.ts b/marketplace-ui/src/app/modules/product/product-detail/product-detail.component.ts
@@ -173,7 +173,6 @@ export class ProductDetailComponent {
         this.updateDropdownSelection();
         this.checkMediaSize();
         this.showPopup = res.params['showPopup'] === 'true';
-        console.log(this.showPopup);
 
         if (this.showPopup && this.authService.getToken()) {
           this.appModalService
@@ -422,7 +421,7 @@ export class ProductDetailComponent {
     }
   }
 
-  getDisplayedTabsSignal(): ItemDropdown<string>[] {
+  getDisplayedTabsSignal(): ItemDropdown[] {
     this.updateWebBrowserTitle();
     const displayedTabs: ItemDropdown[] = [];
     for (const detailTab of this.detailTabs) {

diff --git a/marketplace-ui/src/app/shared/components/loading-spinner/loading-spinner.component.ts b/marketplace-ui/src/app/shared/components/loading-spinner/loading-spinner.component.ts
@@ -8,8 +8,8 @@ import { LoadingService } from '../../../core/services/loading/loading.service';
   styleUrl: './loading-spinner.component.scss'
 })
 export class LoadingSpinnerComponent {
-  @Input() key: string = '';
-  @Input() containerClasses: string = '';
+  @Input() key = '';
+  @Input() containerClasses = '';
   loadingService = inject(LoadingService);
   isLoading = computed(() => this.loadingService.loadingStates()[this.key]);
 }
diff --git a/marketplace-ui/src/app/shared/pipes/product-type.pipe.ts b/marketplace-ui/src/app/shared/pipes/product-type.pipe.ts
@@ -6,6 +6,10 @@ import { Pipe, PipeTransform } from '@angular/core';
 })
 export class ProductTypePipe implements PipeTransform {
   transform(type: string, _args?: []): string {
-    return type ? `common.filter.value.${type}` : '';
+    let i18nKey = '';
+    if (type) {
+      i18nKey = `common.filter.value.${type}`;
+    }
+    return i18nKey;
   }
 }
diff --git a/marketplace-ui/src/app/shared/services/app-modal.service.ts b/marketplace-ui/src/app/shared/services/app-modal.service.ts
@@ -18,7 +18,7 @@ export class AppModalService {
     });
   }
 
-  openAddFeedbackDialog(): Promise<any> {
+  openAddFeedbackDialog() {
     const addFeedbackDialog = this.modalService.open(
       AddFeedbackDialogComponent,
       {

diff --git a/marketplace-ui/src/app/shared/services/routing.query.param.service.ts b/marketplace-ui/src/app/shared/services/routing.query.param.service.ts
@@ -76,6 +76,6 @@ export class RoutingQueryParamService {
   getNavigationStartEvent(): Observable<NavigationStart> {
     return this.router.events.pipe(
       filter(event => event instanceof NavigationStart)
-    ) as Observable<NavigationStart>;
+    );
   }
 }