MARP-1642 Application Freezing due to missing product detail content (#…

…258)
axonivy-market · Dec 13, 2024 · 4439b5d · 4439b5d
1 parent d89c12a
commit 4439b5d
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/marketplace-ui/src/app/modules/product/product-detail/product-detail.component.html b/marketplace-ui/src/app/modules/product/product-detail/product-detail.component.html
@@ -160,7 +160,7 @@ <h4 class="analysis-title text-primary text-capitalize mb-0">
                   [id]="displayedTab.value"
                   role="tabpanel"
                   [attr.aria-labelledby]="displayedTab.value + '-tab'">
-                  @if (displayedTab.value === 'dependency') {
+                  @if (displayedTab.value === 'dependency' && productDetail().productModuleContent) {
                     <app-product-detail-maven-content
                       [productDetail]="productDetail()"
                       [selectedVersion]="selectedVersion">

diff --git a/marketplace-ui/src/app/modules/product/product-detail/product-detail.component.spec.ts b/marketplace-ui/src/app/modules/product/product-detail/product-detail.component.spec.ts
@@ -808,4 +808,20 @@ describe('ProductDetailComponent', () => {
     expect(rateConnector.childNodes[0].nativeNode.textContent).toContain("common.feedback.rateFeedbackForUtilityBtnLabel");
     expect(rateConnectorEmptyText.childNodes[0].nativeNode.textContent).toContain("common.feedback.noFeedbackForUtilityLabel");
   });
+
+  it('maven tab should not display when product module content is missing', () => {
+    const event = { value: 'dependency' };
+    component.onTabChange(event.value);
+    fixture.detectChanges();
+    let mavenTab = fixture.debugElement.query(
+      By.css('app-product-detail-maven-content')
+    );
+    expect(mavenTab).toBeTruthy();
+    component.productModuleContent.set({} as any as ProductModuleContent);
+    fixture.detectChanges();
+    mavenTab = fixture.debugElement.query(
+      By.css('app-product-detail-maven-content')
+    );
+    expect(mavenTab).toBeFalsy();
+  });
 });