MARP-975 Handle Feedbacks

axonivy-market · Dec 23, 2024 · 12220ae · 12220ae
1 parent 8ab4b1f
commit 12220ae
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 7 deletions.
diff --git a/...ace-service/src/test/java/com/axonivy/market/controller/ProductDetailsControllerTest.java b/...ace-service/src/test/java/com/axonivy/market/controller/ProductDetailsControllerTest.java
@@ -8,7 +8,6 @@
 import com.axonivy.market.enums.Language;
 import com.axonivy.market.model.MavenArtifactVersionModel;
 import com.axonivy.market.model.ProductDetailModel;
-import com.axonivy.market.model.VersionAndUrlModel;
 import com.axonivy.market.service.ProductService;
 import com.axonivy.market.service.VersionService;
 import com.fasterxml.jackson.databind.ObjectMapper;

diff --git a/...etplace-service/src/test/java/com/axonivy/market/service/impl/ProductServiceImplTest.java b/...etplace-service/src/test/java/com/axonivy/market/service/impl/ProductServiceImplTest.java
@@ -414,20 +414,20 @@ void testGetCompatibilityRangeAfterFetchProductDetail() {
     when(productRepo.getProductByIdAndVersion(MOCK_PRODUCT_ID, MOCK_SNAPSHOT_VERSION))
         .thenReturn(getMockProduct());
     when(versionService.getVersionsForDesigner(MOCK_PRODUCT_ID))
-        .thenReturn(mockVersionAndUrlModels(),mockVersionModels(),mockVersionModels2(),mockVersionModels3());
+        .thenReturn(mockVersionAndUrlModels(), mockVersionModels(), mockVersionModels2(), mockVersionModels3());
 
 
     Product result = productService.fetchProductDetail(MOCK_PRODUCT_ID, true);
-    assertEquals(result.getCompatibilityRange(),"10.0+");
+    assertEquals("10.0+", result.getCompatibilityRange());
 
     result = productService.fetchProductDetail(MOCK_PRODUCT_ID, true);
-    assertEquals(result.getCompatibilityRange(),"10.0-11.3+");
+    assertEquals("10.0-11.3+", result.getCompatibilityRange());
 
     result = productService.fetchProductDetail(MOCK_PRODUCT_ID, true);
-    assertEquals(result.getCompatibilityRange(),"10.0-11.3+");
+    assertEquals("10.0-11.3+", result.getCompatibilityRange());
 
     result = productService.fetchProductDetail(MOCK_PRODUCT_ID, true);
-    assertEquals(result.getCompatibilityRange(),"10.0-12.0+");
+    assertEquals("10.0-12.0+", result.getCompatibilityRange());
   }
 
   @Test

diff --git a/...oduct-detail/product-detail-information-tab/product-detail-information-tab.component.html b/...oduct-detail/product-detail-information-tab/product-detail-information-tab.component.html
@@ -17,7 +17,7 @@ <h3 [lang]="languageService.selectedLanguage()" class="info-title text-primary">
       alt="Logo Vendor"/>
     </a>
   </div>
-  @if(productDetail?.compatibilityRange) {
+  @if(productDetail.compatibilityRange) {
     <hr class="border-top-0" />
     <div class="d-flex flex-row justify-content-between p-0">
       <span [lang]="languageService.selectedLanguage()" class="text-secondary">