Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MARP-1386 Change date data type #72

Merged
merged 1 commit into from
Dec 18, 2024
Merged

MARP-1386 Change date data type #72

merged 1 commit into from
Dec 18, 2024

Conversation

nntthuy-axonivy
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

Test Results

11 tests  +11   11 ✅ +11   9s ⏱️ +9s
 6 suites + 6    0 💤 ± 0 
 6 files   + 6    0 ❌ ± 0 

Results for commit 42d86f6. ± Comparison against base commit d2d3a65.

@github-actions github-actions bot added the bug Something isn't working label Dec 12, 2024
ndkhanh-axonivy
ndkhanh-axonivy approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@ndkhanh-axonivy ndkhanh-axonivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nntthuy-axonivy nntthuy-axonivy marked this pull request as ready for review December 17, 2024 04:09
@nntthuy-axonivy
Copy link
Contributor Author

Hi @ivy-rew, I made some enhancements by changing Timestamp to Date and test update. Could you help me take a look at it?

@ivy-rew
Copy link
Member

ivy-rew commented Dec 17, 2024

Looks good, thanks. Closes #64

@nntthuy-axonivy nntthuy-axonivy merged commit 88447ea into master Dec 18, 2024
5 of 6 checks passed
@nntthuy-axonivy nntthuy-axonivy deleted the bugfix/MARP-1386-Change-date-data-type branch December 18, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndkhanh-axonivy ndkhanh-axonivy ndkhanh-axonivy approved these changes

@ivy-rew ivy-rew ivy-rew approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nntthuy-axonivy @ivy-rew @ndkhanh-axonivy