Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/XIVY-13085 add business notification demo #514

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

weissreto
Copy link
Member

No description provided.

@weissreto weissreto force-pushed the feature/XIVY-13085_add_notification_demo branch from 85b942b to 50efafc Compare February 22, 2024 16:32
@weissreto weissreto requested a review from ivy-rew February 22, 2024 16:33

@Test
void runProcess(BpmClient bpmClient)
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

legacy fromatting ;-)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the whole demo is formatted this way.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can change in a a different PR. But then all demos.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have changed this class to legazy formatting only. Will convert every demo to new formatting in a new PR after my holidays.

"config" : {
"data" : "workflow.order.OrderData"
},
"elements" : [ {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add an 'annotation' on this process, explaining the purpose of this demo. ... as you see e.g. in procurementRequest

"type" : "DialogCall",
"name" : "Input Order",
"config" : {
"dialog" : "workflow.order.InputOrder:start()",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the initial order form is empty ... which is realistic, but bad for demonstrations.
I'd prefil the order form with 'John Doe' and the Ferrari you are also using in tests.
So I can demonstrate the feature without touching the keyboard...

Copy link
Member

@ivy-rew ivy-rew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff; some small ideas for improvement

@weissreto weissreto force-pushed the feature/XIVY-13085_add_notification_demo branch 2 times, most recently from 381ec31 to 21fafce Compare February 23, 2024 08:37
"name" : [
"**Business Notification Demo**",
"",
"This demo shows you how you can send business notifications in your process.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double 'you' --> This demo shows how you can ...

"**Business Notification Demo**",
"",
"This demo shows you how you can send business notifications in your process.",
"Starts with the simplest way first, then shows how you can use process data in your messages, use multi-lingual messages, and finally how to use templates."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It starts ....

Add a new demo process 'OrderProcess' that demonstrates the different
use cases how the BusinessNotification API can be used.

Add a test for the new process
@weissreto weissreto force-pushed the feature/XIVY-13085_add_notification_demo branch from 21fafce to 9dffa34 Compare February 23, 2024 08:46
@weissreto weissreto merged commit 48a8cb4 into master Feb 23, 2024
1 check passed
@weissreto weissreto deleted the feature/XIVY-13085_add_notification_demo branch February 23, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants