-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/XIVY-13085 add business notification demo #514
Conversation
85b942b
to
50efafc
Compare
|
||
@Test | ||
void runProcess(BpmClient bpmClient) | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
legacy fromatting ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the whole demo is formatted this way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can change in a a different PR. But then all demos.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have changed this class to legazy formatting only. Will convert every demo to new formatting in a new PR after my holidays.
"config" : { | ||
"data" : "workflow.order.OrderData" | ||
}, | ||
"elements" : [ { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd add an 'annotation' on this process, explaining the purpose of this demo. ... as you see e.g. in procurementRequest
"type" : "DialogCall", | ||
"name" : "Input Order", | ||
"config" : { | ||
"dialog" : "workflow.order.InputOrder:start()", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the initial order form is empty ... which is realistic, but bad for demonstrations.
I'd prefil the order form with 'John Doe' and the Ferrari you are also using in tests.
So I can demonstrate the feature without touching the keyboard...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good stuff; some small ideas for improvement
381ec31
to
21fafce
Compare
"name" : [ | ||
"**Business Notification Demo**", | ||
"", | ||
"This demo shows you how you can send business notifications in your process.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
double 'you' --> This demo shows how you can ...
"**Business Notification Demo**", | ||
"", | ||
"This demo shows you how you can send business notifications in your process.", | ||
"Starts with the simplest way first, then shows how you can use process data in your messages, use multi-lingual messages, and finally how to use templates." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It starts ....
Add a new demo process 'OrderProcess' that demonstrates the different use cases how the BusinessNotification API can be used. Add a test for the new process
21fafce
to
9dffa34
Compare
No description provided.