Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added plugin repositories. #3

Merged
2 commits merged into from
Oct 10, 2024
Merged

Added plugin repositories. #3

2 commits merged into from
Oct 10, 2024

Conversation

peters-axon
Copy link
Collaborator

No description provided.

@ivy-rew ivy-rew requested a review from a user October 10, 2024 09:40
@ivy-rew
Copy link
Member

ivy-rew commented Oct 10, 2024

@linhpd-axonivy is there any public documentation available how to make the connector compatible with the dev-build? I can't find anything related to this topic in the official wiki
https://github.com/axonivy-market/market/wiki/c3-Market-Integration

@ivy-rew
Copy link
Member

ivy-rew commented Oct 10, 2024

@linhpd-axonivy is there any public documentation available how to make the connector compatible with the dev-build? I can't find anything related to this topic in the official wiki https://github.com/axonivy-market/market/wiki/c3-Market-Integration

IMHO making the connector build compatible with the dev-pipeline is a complex task to do. This provokes frustration and forces our users to dive deep into Maven, which is something we want to avoid at any rate due to the steep learning curve that must be mastered. I think it would if Octopus takes that responsibility to setup the pipeline for dev compatibility. 💪
We should not bother the original developers with such frustrating work. 🤷

What do you think @linhpd-axonivy @ivy-sgi

@ghost
Copy link

ghost commented Oct 10, 2024

Hi @ivy-rew ,
I checked with our team, and unfortunately, it seems we did not update any documentation for the dev-build. I think we also need to update the product-template.

Since Sabine is on vacation, @nqhoan-axonivy , could you help me take note of this issue?

@ghost ghost merged commit 485e99b into axonivy-market:master Oct 10, 2024
2 checks passed
@ivy-rew
Copy link
Member

ivy-rew commented Oct 10, 2024

Hi @ivy-rew , I checked with our team, and unfortunately, it seems we did not update any documentation for the dev-build. I think we also need to update the product-template.

Since Sabine is on vacation, @nqhoan-axonivy , could you help me take note of this issue?

the problem is that the heavy parts of the configuration live in the pom.xml the user is creating during the project setup. So you can't set them up for the user beforehand in the template.

Besides this, it's a highly repetitive task, that you may even automate in a build job. But even if there would be documentation, I think it's overwhelming for normal ivy users and if something fails, requests to ivy-team are being to the rescue.

So I think it would be better if you/Ocotpus takes this responsibility. Sort of a post-onboarding step that you do after the contribution was added. Maybe even with a simple script that does the job for you 🤖

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants