Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/marp 826 alfresco ecm build release for this connector for designer 11.3 #43

Conversation

vhhoang-axonivy
Copy link
Contributor

No description provided.

Copy link
Contributor

github-actions bot commented Aug 13, 2024

Test Results

1 tests  ±0   1 ✅ +1   9s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 3e04a5b. ± Comparison against base commit 734c13c.

♻️ This comment has been updated with latest results.

<artifactId>alfresco-connector-test</artifactId>
<version>11.3.1-SNAPSHOT</version>
<packaging>iar</packaging>
<properties>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't format this file, just change versions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted to original format.

@@ -32,7 +32,7 @@ public void callReadDocuments(BpmClient bpmClient, ISession session) {
SubProcessCallResult result = bpmClient.start()
.subProcess(CALL_READ_DOCUMENTS).as().session(session)
.execute("-shared-").subResult();
assertThat(result.param("connectionError", String.class)).isEmpty();
assertThat(result.param("connectionError", String.class)).isEmpty();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

follow the format of the file. Don't use two format types in a file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted to original format.

@@ -35,7 +35,7 @@
</p:panel>
<p:panel id="datapanel"
rendered="#{data.connectionError == null or data.connectionError.length() == 0}">
<p:repeat var="folder" value="#{data.folder}">
<ui:repeat var="folder" value="#{data.folder}">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it changed by you or Ivy team?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is changed by Ivy.

Copy link
Contributor

@phhung-axonivy phhung-axonivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vhhoang-axonivy vhhoang-axonivy merged commit f44ac7b into master Aug 19, 2024
2 of 3 checks passed
@vhhoang-axonivy vhhoang-axonivy deleted the feature/MARP-826-Alfresco-ECM-Build-release-for-this-connector-for-designer-11.3 branch August 19, 2024 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants