-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/marp 826 alfresco ecm build release for this connector for designer 11.3 #43
Feature/marp 826 alfresco ecm build release for this connector for designer 11.3 #43
Conversation
alfresco-connector-test/pom.xml
Outdated
<artifactId>alfresco-connector-test</artifactId> | ||
<version>11.3.1-SNAPSHOT</version> | ||
<packaging>iar</packaging> | ||
<properties> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't format this file, just change versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted to original format.
@@ -32,7 +32,7 @@ public void callReadDocuments(BpmClient bpmClient, ISession session) { | |||
SubProcessCallResult result = bpmClient.start() | |||
.subProcess(CALL_READ_DOCUMENTS).as().session(session) | |||
.execute("-shared-").subResult(); | |||
assertThat(result.param("connectionError", String.class)).isEmpty(); | |||
assertThat(result.param("connectionError", String.class)).isEmpty(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
follow the format of the file. Don't use two format types in a file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted to original format.
@@ -35,7 +35,7 @@ | |||
</p:panel> | |||
<p:panel id="datapanel" | |||
rendered="#{data.connectionError == null or data.connectionError.length() == 0}"> | |||
<p:repeat var="folder" value="#{data.folder}"> | |||
<ui:repeat var="folder" value="#{data.folder}"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it changed by you or Ivy team?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is changed by Ivy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.