Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marp 8 adobe sign connector finishing #2

Merged
merged 24 commits into from
Sep 28, 2023
Merged

Marp 8 adobe sign connector finishing #2

merged 24 commits into from
Sep 28, 2023

Conversation

stefanmasek
Copy link
Contributor

  • OAuth authentication implemented
  • Admin Setup page to setup Variables and request OAuth token
  • Product documentation
  • Enhanced Demo page
  • Created base tests for the services

@stefanmasek
Get test OAuth authentication working, create URL with dynamic base, …
4791b78 
…remove old dependency
@stefanmasek
Improve getting base url from request
cf4342d
@stefanmasek
OAuth token storing to Variable, dialog for auth setup
148dd39
@stefanmasek
use integration key if set, else use oauth
74691f9
@stefanmasek
Admin Setup dialog for global variables
b48f953
@stefanmasek
request token retrieving and setup in Admin page
dee0e27
@stefanmasek
add redirect uri to admin setup page, create setup documentation
90d2795
@stefanmasek
fix doc images
3405ad6
@stefanmasek
fix integration key doc images
edec674
@stefanmasek
fix integration key doc images
1b434bf
@stefanmasek
fix issue with storing refreshed tokens, improve admin page and docum…
b2a70e6 
…entation
@stefanmasek
Variables, projects configuration
1ba7d30
@stefanmasek
Demo documentation
ee2d720
@stefanmasek
create test project
b0d3a39
@stefanmasek
service mocks and test base
6e59fdf
@stefanmasek
remove commented code, fill repo readme
5293d9c
@stefanmasek
fix readme
25c17e7
@stefanmasek
enhance demo, fix return url for multiple signers, update demo doc an…
d8c22a9 
…d configuration
@stefanmasek
fix modules pom
dfd8474
@stefanmasek
set build plugin version on demo project
2e883fe
@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2023 •
edited
Loading

Test Results

5 tests  +5   5 ✔️ +5   21s ⏱️ +21s
2 suites +2   0 💤 ±0 
2 files   +2   0 ❌ ±0 

Results for commit 3baa634. ± Comparison against base commit 7d8990e.

♻️ This comment has been updated with latest results.

@ivy-sgi ivy-sgi requested review from juergen-plohn, ivy-rew and nqhoan-axonivy and removed request for ivy-rew and juergen-plohn September 20, 2023 15:15
ntqdinh-axonivy
ntqdinh-axonivy reviewed Sep 22, 2023
View reviewed changes
Copy link
Contributor

@ntqdinh-axonivy ntqdinh-axonivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @stefanmasek
I found some warning form maven build in GitHub Action record. Can you check these warning again:
image

ntqdinh-axonivy
ntqdinh-axonivy reviewed Sep 26, 2023
View reviewed changes
Copy link
Contributor

@ntqdinh-axonivy ntqdinh-axonivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @andreasbalsiger
Could you please check "product readme" from this PR before we process to the next step of publishing to the market?

@ivy-rew
Copy link
Member

ivy-rew commented Sep 27, 2023

Hi @andreasbalsiger Could you please check "product readme" from this PR before we process to the next step of publishing to the market?

I think Andreas in on Holiday. So if this is the only blocker for the merge ... I'd not wait for a response. Still Andreas got his notification about the topic and can contribute it later on ;-)

@ntqdinh-axonivy
Copy link
Contributor

Hi @ivy-rew
We are going to publish this connector to Ivy Market after the merging section and release build is finished. So we just want to make sure everything is ready for publishing :)

Hi @stefanmasek
We are sorry for our team lasting in the review section. We will process this Pr to the next step. Cheers!

@ntqdinh-axonivy ntqdinh-axonivy merged commit 840bc1d into initial_version Sep 28, 2023
4 checks passed
@ntqdinh-axonivy ntqdinh-axonivy deleted the MARP-8-adobe-sign-connector-finishing branch September 28, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntqdinh-axonivy ntqdinh-axonivy ntqdinh-axonivy left review comments

@ivy-rew ivy-rew ivy-rew left review comments

@nqhoan-axonivy nqhoan-axonivy Awaiting requested review from nqhoan-axonivy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefanmasek @ivy-rew @ntqdinh-axonivy