Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(View On GitHub Button): made styles on this button to be consistent with primary button #209

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

echelonnought
Copy link

fixed this issue axios/axios#6020 raised

made the styles on the "View On GitHub" button to be consistent on the landing page.

changes made from this
viewButton

to this
viewOnGitHub

@echelonnought
Copy link
Author

Hello @jasonsaayman, here's another PR raised for this issue. it has been a long standing one, so I opted to fix. Would be glad if you could take a look at it. Thank you!

@jasonsaayman jasonsaayman self-assigned this Nov 5, 2024
Copy link
Member

@jasonsaayman jasonsaayman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DigitalBrainJS
Copy link
Contributor

@jasonsaayman Isn't it important to have primary and secondary button styles here? The emphasis on the "Get Started" button looks quite logical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants