Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add twisted edwards trait + proper constants #22

Merged
merged 8 commits into from
Jan 22, 2024
Merged

fix: add twisted edwards trait + proper constants #22

merged 8 commits into from
Jan 22, 2024

Conversation

shuklaayush
Copy link

No description provided.

@shuklaayush shuklaayush mentioned this pull request Jan 3, 2024
Merged
jonathanpwang
jonathanpwang requested changes Jan 22, 2024
View reviewed changes
Copy link

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A question about making sure to support is_on_curve for infinity point in CurveExt.

Also if you have the sage commands, it would be nice to include them for reproducibility.

src/ed25519/curve.rs Show resolved Hide resolved
src/ed25519/fq.rs Show resolved Hide resolved
src/ed25519/fr.rs Show resolved Hide resolved
jonathanpwang
jonathanpwang approved these changes Jan 22, 2024
View reviewed changes
Copy link

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathanpwang
Copy link

@shuklaayush unfortunately there is some feature compile issue because of this derive_serde feature. Long term I feel like the halo2-axiom version can probably remove the feature and always have it enabled, but short term please do something like

#[cfg_attr(feature = "derive_serde", derive(Serialize, Deserialize))]

@jonathanpwang jonathanpwang mentioned this pull request Jan 22, 2024
Merged
@shuklaayush
Copy link
Author

@jonathanpwang Done, CI should pass now

@jonathanpwang jonathanpwang merged commit b3b058a into axiom-crypto:feat/ed25519 Jan 22, 2024
7 checks passed
@shuklaayush shuklaayush deleted the feat/ed25519-constant-fixes branch January 23, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanpwang jonathanpwang jonathanpwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shuklaayush @jonathanpwang