-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Git Pull Request #74
Git Pull Request #74
Conversation
✅ Deploy Preview for axelerant-engg-handbook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -0,0 +1,27 @@ | |||
--- | |||
title: Pull Request (PR) | |||
weight: 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Yemaneberhan-Lemma, IIRC, the branching and merging had a weight of 4. It doesn’t make sense to talk about pull requests before talking about branching, no?
|
||
# Pull Request (PR) | ||
|
||
A Git PR, or pull request, is a way to propose changes to the codebase. Post review your changes are merged. This process helps to ensure that changes are reviewed by someone else, which reduces the chances of any errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let’s make it clear that PR is a GitHub or GitLab feature (called MR over there). Git doesn’t need anything called pull requests.
|
||
## PR failures/debugging/troubleshoot | ||
|
||
Github makes some checks against our PR to see if it is ready to be merged. Failing these checks is considered a failing of PR, or simply PR failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see this document doesn’t mention GitHub Actions at all. I think it is important to mention that.
Created a page about Git Pull Request