Git Pull Request #74
Merged
Git Pull Request #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for axelerant-engg-handbook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hussainweb
requested changes
Jul 31, 2023
| @@ -0,0 +1,27 @@ | |||
| --- | |||
| title: Pull Request (PR) | |||
| weight: 2 | |||
There was a problem hiding this comment.
@Yemaneberhan-Lemma, IIRC, the branching and merging had a weight of 4. It doesn’t make sense to talk about pull requests before talking about branching, no?
|
|
||
| # Pull Request (PR) | ||
|
|
||
| A Git PR, or pull request, is a way to propose changes to the codebase. Post review your changes are merged. This process helps to ensure that changes are reviewed by someone else, which reduces the chances of any errors. |
There was a problem hiding this comment.
Let’s make it clear that PR is a GitHub or GitLab feature (called MR over there). Git doesn’t need anything called pull requests.
|
|
||
| ## PR failures/debugging/troubleshoot | ||
|
|
||
| Github makes some checks against our PR to see if it is ready to be merged. Failing these checks is considered a failing of PR, or simply PR failed. |
There was a problem hiding this comment.
I see this document doesn’t mention GitHub Actions at all. I think it is important to mention that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a page about Git Pull Request