fix(minor-ampd): update sui module emitting events #643
+3
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milapsheth
commented
Oct 1, 2024
| @@ -22,11 +22,7 @@ impl EventType { | |||
| EventType::ContractCall => "ContractCall", | |||
There was a problem hiding this comment.
Merge this PR in coordination with other repos, so e2e tests don't break
There was a problem hiding this comment.
we don't have e2e test for this
There was a problem hiding this comment.
Joao added Sui -> Amplifier last week
haiyizxx
approved these changes
Oct 1, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #643 +/- ##
==========================================
- Coverage 93.55% 93.55% -0.01%
==========================================
Files 242 242
Lines 34080 34079 -1
==========================================
- Hits 31884 31883 -1
Misses 2196 2196
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AXE-5572
Todos
Steps to Test
Expected Behaviour
Other Notes