Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce native support for config stores, core, SQS and SNS module #856

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

MatejNedic
Copy link
Member

@MatejNedic MatejNedic commented Aug 1, 2023

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Currently creating native image for using core, both configs, SQS and SNS work and polls on start of native executable.
Closes #673 and partially #468

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated reference documentation to reflect the change
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions github-actions bot added the component: sqs SQS integration related issue label Aug 2, 2023
@MatejNedic MatejNedic marked this pull request as ready for review August 2, 2023 18:58
@MatejNedic MatejNedic changed the title Draft: Introduce native support for config stores and core module Introduce native support for config stores, core and SQS module Aug 2, 2023
@github-actions github-actions bot added the component: sns SNS integration related issue label Aug 4, 2023
@MatejNedic MatejNedic added component: secrets-manager Secrets Manager integration related issue component: parameter-store Parameter Store integration related issue labels Aug 4, 2023
@MatejNedic MatejNedic changed the title Introduce native support for config stores, core and SQS module Introduce native support for config stores, core, SQS and SNS module Aug 4, 2023
@github-actions github-actions bot added the component: s3 S3 integration related issue label Aug 4, 2023
@romangr
Copy link

romangr commented Oct 17, 2023

@MatejNedic nice to see there's a movement towards native build support, are there any rough estimates when this PR will be merged?

@MatejNedic
Copy link
Member Author

Hey hey @romangr , hopefully soon! Will work on this during a weekend

@romangr
Copy link

romangr commented Oct 19, 2023

@MatejNedic cool, thank you for your work!

Copy link
Contributor

@maciejwalkowiak maciejwalkowiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to run all our integration tests in a context of native image? As much as I believe that this PR works, how can we ensure that all functionality added in the future also works in the context of native image?

@github-actions github-actions bot added the type: dependency-upgrade Dependency version bump label Jun 17, 2024
@MatejNedic
Copy link
Member Author

@maciejwalkowiak @tomazfernandes

Let merge this I have tested it and it works properly. We can always add hints when people report issues.

# Conflicts:
#	spring-cloud-aws-dependencies/pom.xml
#	spring-cloud-aws-s3/src/main/java/io/awspring/cloud/s3/S3RuntimeHints.java
@klopfdreh
Copy link
Contributor

klopfdreh commented Jun 24, 2024

Hey @MatejNedic and @maciejwalkowiak - just a heads up - there is a new version for AWS SDK V2 and AWS CRT which both supports Spring Boot Native, now - see: aws/aws-sdk-java-v2#5290 / aws/aws-sdk-java-v2#5184 and awslabs/aws-crt-java#749

Can you bump the version of the AWS SDK V2 to a newer version?

This is important when you want to use the S3TransferManager to use Multipart-Uploads

@MatejNedic
Copy link
Member Author

Hey @klopfdreh ,
Already updqted maven last week :)

@klopfdreh
Copy link
Contributor

When this PR will be merged? 😄

Currently we have to take care of resource and everthing else like:

{
  "resources": [
    {
      "pattern": "io/awspring/cloud/core/SpringCloudClientConfiguration.properties"
    },
    {
      "pattern": "io/awspring/cloud/s3/S3ObjectContentTypeResolver.properties"
    }
  ]
}

and all other stuff you wrote hints for.

@MatejNedic
Copy link
Member Author

@maciejwalkowiak lets merge this and release it in 3.2.0

@MatejNedic MatejNedic added this to the 3.2.0 milestone Aug 1, 2024
@meletis
Copy link

meletis commented Aug 1, 2024

@MatejNedic , any reason why this is not compatible with 3.1.2?

@ksanjeev9211
Copy link

When are we going to get this PR merged?

@maciejwalkowiak maciejwalkowiak modified the milestones: 3.2.0, 3.3.x Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: core Core functionality related issue component: parameter-store Parameter Store integration related issue component: s3 S3 integration related issue component: secrets-manager Secrets Manager integration related issue component: sns SNS integration related issue component: sqs SQS integration related issue type: dependency-upgrade Dependency version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In Native image SpringCloudClientConfiguration.properties file is missing
6 participants