Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix publish issue #706

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Fix publish issue #706

merged 2 commits into from
Nov 8, 2023

Conversation

webern
Copy link
Contributor

@webern webern commented Nov 7, 2023

Issue #, if available:

#700
Arises from #660, 967e02d

Description of changes:

    remove unused lines from deny.toml
    deny.toml: allow-wildcard-paths

    failure-server is an internal package used only in testing that we do
    not want to publish to crates.io. When including it in tough's dev-
    dependencies, it is necessary to do so without a version number or else
    cargo publish will fail. The lack of version number causes cargo deny
    to ban failure-server as a wildcard-versioned dependency. The following
    line allows us to refer to our own internal packages without a version
    number.

Testing

Used cargo publish --dry-run to verify this fixes the problem.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

deny.toml Outdated Show resolved Hide resolved
deny.toml Outdated Show resolved Hide resolved
deny.toml Outdated Show resolved Hide resolved
deny.toml Show resolved Hide resolved
failure-server is an internal package used only in testing that we do
not want to publish to crates.io. When including it in tough's dev-
dependencies, it is necessary to do so without a version number or else
cargo publish will fail. The lack of version number causes cargo deny
to ban failure-server as a wildcard-versioned dependency. The following
line allows us to refer to our own internal packages without a version
number.
@webern webern force-pushed the fix-publish-issue branch from c57905b to 3655b01 Compare November 7, 2023 23:33
@webern webern merged commit 3c36347 into awslabs:develop Nov 8, 2023
9 checks passed
@webern webern deleted the fix-publish-issue branch November 8, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants