Fix: github pages build #195
Conversation
edgarsilva948
requested review from
nabuskey,
vara-bonthu,
nimakaviani,
candonov,
csantanapr,
7navyasa and
johnphilips3
as code owners
| - name: "argocd" | ||
| namespaceSelector: | ||
| matchNames: | ||
| - "argocd" | ||
| podMetricsEndpoints: | ||
| - port: "metrics" | ||
| selector: {} |
There was a problem hiding this comment.
Crossplane has a podmonitor because the family provider pods don't have a service. Since ArgoCD has a service, it is better to add a servicemonitor for it.
| revision: 1 | ||
| datasource: prometheusdatasource | ||
| ekscontrolplane: | ||
| gnetId: 21192 |
There was a problem hiding this comment.
nice one! The instances and control plane nodes version can be timeseries count and the version in the legend. With 3 nodes is ok but 300 would be hard to see. Merging this PR is not dependent on that update.
| module "gatekeeper" { | ||
| source = "aws-ia/eks-blueprints-addon/aws" | ||
| version = "1.1.1" |
There was a problem hiding this comment.
If this works but the addon doesn't, can you file an issue on the addon repo and link here?
There was a problem hiding this comment.
I noticed the Gatekeeper deployment's liveness probe doesn't have an initialDelaySeconds set, or it's too low. This can be a problem when not all cluster pods (like coredns, vpc-cpi, etc.) are up and running right away. If Gatekeeper starts too early, it doesn’t retry enough times and fail.
To work around this, I added a dependency, forcing Gatekeeper to wait until all the addons are up and running, which seems to work now. I will see if I can open a PR to adjust this in the addon repo.
What does this PR do?
This PR fixes the existing issues with the GitHub Pages build process. it also introduces a new feature that allows users to switch between light and dark modes, enhancing UX of the doc.
here's my forked repo working: https://edgarsilva948.github.io/crossplane-on-eks/
we need to adjust the Repository -> Settings -> Pages to be:
More
Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
Yes, I have added a new example under examples to support my PR
[] Yes, I have updated the docs for this feature
Yes, I have linked to an issue or feature request (applicable to PRs that solves a bug or a feature request)
Note:
For Moderators
Additional Notes
N/A