Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to improve tutorial usage experience #141

Merged
merged 16 commits into from
Aug 18, 2023
Merged

Conversation

seshubaws
Copy link
Contributor

What does this PR do?

  1. Updated Kubernetes version of EKS cluster
  2. Instead of installing all upbound providers, which could overload the k8s control plane and render the newly created cluster useless, added a providers.yaml file to install after cluster creation for only the necessary providers
  3. Added permissions for the user to be able to view, edit, and delete the KMS key created

Motivation

Trying to make the EKS cluster bootstrap with Terraform tutorial more user friendly

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)

  • Yes, I have added a new example under examples to support my PR

  • Yes, I have updated the docs for this feature

  • Yes, I have linked to an issue or feature request (applicable to PRs that solves a bug or a feature request)

Note:

  • Not all the PRs require examples and docs
  • We prefer small, well tested pull requests. Please ensure your pull requests are self-contained, and commits are squashed

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

Comment on lines 138 to 141
Step1: Delete resources created by Crossplane

Step2: Terraform Destroy

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need step 1 cause tf destroy wouldn't work unless you remove the Crossplane resources.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is within the README for creating the EKS cluster, I thought cleaning up only what was made here would be within scope

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is part of the crossplane-on-eks repo, so it is assumed you would deploy some Crossplane examples from the repo and those need to be cleaned up, otherwise the destroy script won't work.

bootstrap/terraform/main.tf Outdated Show resolved Hide resolved
bootstrap/terraform/providers.yaml Outdated Show resolved Hide resolved
bootstrap/terraform/main.tf Outdated Show resolved Hide resolved
@candonov candonov merged commit d9fd2ac into awslabs:main Aug 18, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants