-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to improve tutorial usage experience #141
Conversation
bootstrap/terraform/README.md
Outdated
Step1: Delete resources created by Crossplane | ||
|
||
Step2: Terraform Destroy | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need step 1 cause tf destroy wouldn't work unless you remove the Crossplane resources.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is within the README for creating the EKS cluster, I thought cleaning up only what was made here would be within scope
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is part of the crossplane-on-eks repo, so it is assumed you would deploy some Crossplane examples from the repo and those need to be cleaned up, otherwise the destroy script won't work.
examples/upbound-aws-provider/composite-resources/serverless-examples/sqs-lambda-s3/README.md
Outdated
Show resolved
Hide resolved
Co-authored-by: candonov <[email protected]>
examples/upbound-aws-provider/composite-resources/serverless-examples/sqs-lambda-s3/README.md
Outdated
Show resolved
Hide resolved
examples/upbound-aws-provider/composite-resources/serverless-examples/sqs-lambda-s3/README.md
Outdated
Show resolved
Hide resolved
Co-authored-by: candonov <[email protected]>
Co-authored-by: candonov <[email protected]>
…xamples/sqs-lambda-s3/README.md Co-authored-by: candonov <[email protected]>
…xamples/sqs-lambda-s3/README.md Co-authored-by: candonov <[email protected]>
What does this PR do?
Motivation
Trying to make the EKS cluster bootstrap with Terraform tutorial more user friendly
More
Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
Yes, I have added a new example under examples to support my PR
Yes, I have updated the docs for this feature
Yes, I have linked to an issue or feature request (applicable to PRs that solves a bug or a feature request)
Note:
For Moderators
Additional Notes