Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding s3-irsa working composition and claim #136

Merged
merged 8 commits into from
Jun 27, 2023
Merged

feat: Adding s3-irsa working composition and claim #136

merged 8 commits into from
Jun 27, 2023

Conversation

candonov
Copy link
Contributor

@candonov candonov commented Jun 21, 2023 •
edited
Loading

What does this PR do?

  • Adds s3-irsa top level composition that pulls the s3 + IAMRole + IRSA Compositions
  • Cleans up the IRSA composition to only create the Role and ServiceAccount (the RolePolicyAttachement is handled by the IAMRole composition)
  • Adds a sample claim

Motivation

We need a good example for demo purposes.

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)

  • Yes, I have added a new example under examples to support my PR

  • Yes, I have updated the docs for this feature

  • Yes, I have linked to an issue or feature request (applicable to PRs that solves a bug or a feature request)

Note:

  • Not all the PRs require examples and docs
  • We prefer small, well tested pull requests. Please ensure your pull requests are self-contained, and commits are squashed

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@candonov candonov marked this pull request as ready for review June 27, 2023 01:16
csantanapr
csantanapr approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@csantanapr csantanapr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the addition and refactor @candonov 🎉

@csantanapr csantanapr merged commit e389376 into awslabs:main Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csantanapr csantanapr csantanapr approved these changes

@nabuskey nabuskey Awaiting requested review from nabuskey nabuskey is a code owner

@vara-bonthu vara-bonthu Awaiting requested review from vara-bonthu vara-bonthu is a code owner

@nimakaviani nimakaviani Awaiting requested review from nimakaviani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@candonov @csantanapr