Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support google tag manager template #45

Merged
merged 8 commits into from
Mar 5, 2024
Merged

feat: support google tag manager template #45

merged 8 commits into from
Mar 5, 2024

Conversation

zhu-xiaowei
Copy link
Contributor

@zhu-xiaowei zhu-xiaowei commented Mar 1, 2024

Description

  1. support google tag manager

General Checklist

  • Added new tests to cover change, if needed
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zhu-xiaowei zhu-xiaowei added the enhancement New feature or request label Mar 1, 2024
@zhu-xiaowei zhu-xiaowei requested a review from zxkane March 1, 2024 09:31
@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (17d59a3) to head (047751d).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #45   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        25           
  Lines         1129      1129           
  Branches       225       225           
=========================================
  Hits          1129      1129           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@zxkane zxkane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add gtm template usage in README

@zhu-xiaowei
Copy link
Contributor Author

add gtm template usage in README

done.

@zxkane zxkane merged commit de64028 into main Mar 5, 2024
4 checks passed
@zxkane zxkane deleted the gtm-template branch March 5, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants