Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: page view events lost due to cached session storage #41

Merged
merged 3 commits into from
Feb 22, 2024
Merged

Conversation

zhu-xiaowei
Copy link
Contributor

Description

  1. fix page view events lost due to cached session storage

General Checklist

  • Added new tests to cover change, if needed
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zhu-xiaowei zhu-xiaowei added the bug Something isn't working label Feb 21, 2024
@zhu-xiaowei zhu-xiaowei requested a review from zxkane February 21, 2024 09:20
@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2483314) 100.00% compared to head (8df95e3) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #41   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        25           
  Lines         1073      1080    +7     
  Branches       202       207    +5     
=========================================
+ Hits          1073      1080    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhu-xiaowei zhu-xiaowei marked this pull request as draft February 22, 2024 00:47
@zhu-xiaowei zhu-xiaowei marked this pull request as ready for review February 22, 2024 05:28
@zxkane zxkane merged commit f07f26c into main Feb 22, 2024
4 checks passed
@zxkane zxkane deleted the fix-page-view branch February 22, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants