Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support adding global attributes when initializing SDK #30

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

zhu-xiaowei
Copy link
Contributor

Description

  1. support adding global attributes when initializing SDK

General Checklist

  • Added new tests to cover change, if needed
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zhu-xiaowei zhu-xiaowei added the enhancement New feature or request label Oct 27, 2023
@zhu-xiaowei zhu-xiaowei requested a review from zxkane October 27, 2023 00:57
@zxkane zxkane force-pushed the global_attributes branch from 4b089e3 to 4362fbd Compare October 27, 2023 03:04
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (617ee9f) 100.00% compared to head (4362fbd) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #30   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines          994       995    +1     
  Branches       183       183           
=========================================
+ Hits           994       995    +1     
Files Coverage Δ
src/provider/ClickstreamProvider.ts 100.00% <100.00%> (ø)
src/types/Analytics.ts 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zxkane zxkane merged commit e41333f into main Oct 27, 2023
4 checks passed
@zxkane zxkane deleted the global_attributes branch October 27, 2023 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants