Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support add global attributes when using Objc api #64

Merged
merged 3 commits into from
Apr 15, 2024

Conversation

zhu-xiaowei
Copy link
Contributor

@zhu-xiaowei zhu-xiaowei commented Apr 11, 2024

Description

  1. support add global attributes when using Objc api
  2. fix test issues

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds using Swift Package Manager
  • All unit tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zhu-xiaowei zhu-xiaowei added the enhancement New feature or request label Apr 11, 2024
@zhu-xiaowei zhu-xiaowei requested a review from zxkane April 11, 2024 09:42
@zhu-xiaowei zhu-xiaowei changed the title feat: support add global attribute when using Objc api feat: support add global attributes when using Objc api Apr 11, 2024
@zhu-xiaowei zhu-xiaowei marked this pull request as draft April 11, 2024 10:33
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.82%. Comparing base (6242310) to head (a6b48eb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #64   +/-   ##
=======================================
  Coverage   96.81%   96.82%           
=======================================
  Files          35       35           
  Lines        1664     1667    +3     
=======================================
+ Hits         1611     1614    +3     
  Misses         53       53           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhu-xiaowei zhu-xiaowei marked this pull request as ready for review April 12, 2024 04:23
@zxkane zxkane merged commit daa98c8 into main Apr 15, 2024
6 checks passed
@zxkane zxkane deleted the initial-global-attribute-objc branch April 15, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants