Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support lazy initialization of the SDK #58

Merged
merged 3 commits into from
Mar 22, 2024
Merged

feat: support lazy initialization of the SDK #58

merged 3 commits into from
Mar 22, 2024

Conversation

zhu-xiaowei
Copy link
Contributor

Description

  1. support lazy initialization of the SDK

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds using Swift Package Manager
  • All unit tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zhu-xiaowei zhu-xiaowei added the enhancement New feature or request label Mar 20, 2024
@zhu-xiaowei zhu-xiaowei requested a review from zxkane March 20, 2024 02:40
@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.74%. Comparing base (a850795) to head (09af345).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
+ Coverage   95.66%   95.74%   +0.07%     
==========================================
  Files          35       35              
  Lines        1986     1999      +13     
==========================================
+ Hits         1900     1914      +14     
+ Misses         86       85       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhu-xiaowei zhu-xiaowei marked this pull request as draft March 20, 2024 03:21
@zhu-xiaowei zhu-xiaowei marked this pull request as ready for review March 20, 2024 06:02
@zxkane zxkane merged commit 32f44a8 into main Mar 22, 2024
6 checks passed
@zxkane zxkane deleted the lazy-init-sdk branch March 22, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants