Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support record items #5

Merged
merged 3 commits into from
Dec 15, 2023
Merged

feat: support record items #5

merged 3 commits into from
Dec 15, 2023

Conversation

zhu-xiaowei
Copy link
Contributor

Description

  1. support record items

General Checklist

  • Added new tests to cover change, if needed
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zhu-xiaowei zhu-xiaowei requested a review from zxkane December 15, 2023 09:30
@zxkane zxkane merged commit 78b9547 into main Dec 15, 2023
5 checks passed
@zxkane zxkane deleted the record_item branch December 15, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zxkane zxkane zxkane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhu-xiaowei @zxkane