Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the issue when initialize SDK without global attribute #11

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

zhu-xiaowei
Copy link
Contributor

@zhu-xiaowei zhu-xiaowei commented Apr 24, 2024

Description

  1. fix the issue when initialize SDK without global attribute

The flutter official doc also has this problem, opened an issue for is.

General Checklist

  • Added new tests to cover change, if needed
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zhu-xiaowei zhu-xiaowei added the bug Something isn't working label Apr 24, 2024
@zhu-xiaowei zhu-xiaowei requested a review from zxkane April 24, 2024 12:40
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2bd5583) to head (7c54c84).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #11   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines           99        99           
=========================================
  Hits            99        99           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zxkane zxkane merged commit 45b28cc into main Apr 25, 2024
5 checks passed
@zxkane zxkane deleted the fix-global-attributes branch April 25, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants