Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: db insert error for no space left #85

Merged
merged 4 commits into from
Aug 23, 2024
Merged

fix: db insert error for no space left #85

merged 4 commits into from
Aug 23, 2024

Conversation

zhu-xiaowei
Copy link
Contributor

@zhu-xiaowei zhu-xiaowei commented Aug 22, 2024

  • PR title and description conform to Pull Request guidelines.

Description of changes:

  1. fix db insert error for no space left
  2. support send event immediately when saving events to sqlite fails

How did you test these changes?
added test case for verify when even insert into db will throw SQLException.

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.04%. Comparing base (0549134) to head (caf41f9).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ution/clickstream/client/db/ClickstreamDBUtil.java 71.42% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #85      +/-   ##
============================================
+ Coverage     87.93%   88.04%   +0.11%     
- Complexity      488      492       +4     
============================================
  Files            40       40              
  Lines          1716     1732      +16     
  Branches        171      171              
============================================
+ Hits           1509     1525      +16     
- Misses          140      141       +1     
+ Partials         67       66       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhu-xiaowei zhu-xiaowei requested a review from zxkane August 22, 2024 13:59
@zhu-xiaowei zhu-xiaowei self-assigned this Aug 22, 2024
@zhu-xiaowei zhu-xiaowei added the bug Something isn't working label Aug 22, 2024
@zxkane zxkane merged commit b2811de into main Aug 23, 2024
6 checks passed
@zxkane zxkane deleted the fix-db-full-issue branch August 23, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants