Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter two consecutive identical scree view events #65

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

zhu-xiaowei
Copy link
Contributor

  • PR title and description conform to Pull Request guidelines.

Description of changes:

  1. filter two consecutive identical scree view events

How did you test these changes?
added new test case for two consecutive identical scree view events

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zhu-xiaowei zhu-xiaowei requested a review from zxkane February 21, 2024 07:12
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5c61666) 87.20% compared to head (d9797bd) 87.26%.

Files Patch % Lines
...solution/clickstream/client/ScreenRefererTool.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #65      +/-   ##
============================================
+ Coverage     87.20%   87.26%   +0.06%     
- Complexity      454      455       +1     
============================================
  Files            42       42              
  Lines          1665     1665              
  Branches        152      152              
============================================
+ Hits           1452     1453       +1     
  Misses          135      135              
+ Partials         78       77       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zxkane zxkane merged commit 18c6b8c into main Feb 21, 2024
6 checks passed
@zxkane zxkane deleted the filter_same_screen_view_event branch February 21, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants