Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Security Hub Module #159

Closed
wants to merge 12 commits into from
Closed

Conversation

yashbindlish
Copy link

Issue #, if available:

Description of changes: added AWS Security Hub Module

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

detail-type:
- "Security Hub Findings - Imported"
source:
- "aws.securityhub"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this means that the data collection account should be a delegated admin for SH?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can or cannot. Account where Data collection is enabled along with SH. It can also be a delegated admin account where Data collection is running as well. Idea is, that the customer should enable at the main account and then can enable QuickSight access to other admins

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment about this to Readme? That Data Collection account must be an Admin or Delegated admin of SH?

Key: !Ref StepFunctionTemplate
DefinitionSubstitutions:
AccountCollectorLambdaARN: !Ref AccountCollectorLambdaARN
ModuleLambdaARN: !GetAtt LambdaFunction.Arn
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need StepFunction here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed StepFunction reference

Type: AWS::Lambda::Function
Properties:
FunctionName: !Sub '${ResourcePrefix}${CFDataName}-Lambda'
Description: !Sub "Lambda function to retrieve ${CFDataName}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it to retrieve or to transform?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

transform

@iakov-aws
Copy link
Contributor

closing in favor of #161

@iakov-aws iakov-aws closed this Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants