Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

35 defensive html parsing #36

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ericdbarry
Copy link

Issue #, if available:
35

Description of changes:
Two problems trying to use this module on our internal login page - neither of them were coding issues with our page but were instead standard HTML entities not being parsed like they should have been.

I added two tests for the issues I found and then added in the code to fix them.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

Codecov Report

Merging #36 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #36   +/-   ##
======================================
  Coverage    98.1%   98.1%           
======================================
  Files           5       5           
  Lines         317     317           
  Branches       42      42           
======================================
  Hits          311     311           
  Misses          3       3           
  Partials        3       3
Impacted Files Coverage Δ
awsprocesscreds/saml.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a216e70...b864ab8. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants