chore: Add aws_json error code tests #1798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbelkins
changed the title
jbelkins
changed the title
jbelkins
commented
Oct 22, 2024
| "aws.protocoltests.restjson#FooError:http://internal.amazon.com/coral/com.amazon.coral.validate/" | ||
| ] | ||
|
|
||
| // MARK: - error code decoding & sanitization |
There was a problem hiding this comment.
Tests are added below to ensure that error code can be decoded no matter which of the allowed places it is located.
jbelkins
commented
Oct 22, 2024
| ) else { | ||
| XCTFail("Something is wrong with the created http response") | ||
| return | ||
| } |
There was a problem hiding this comment.
The logic above is extracted to a helper method, defined below.
jbelkins
commented
Oct 22, 2024
| } | ||
|
|
||
| func testSanitizeErrorName() async throws { | ||
| let errorCodes = [ |
There was a problem hiding this comment.
These error codes match the ones used for AWS JSON
sichanyoo
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Note that are no actual code changes in this PR, only tests. Upon close examination, the logic for error codes is correct but it was untested.
New/existing dependencies impact assessment, if applicable
No new dependencies were added to this change.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.