Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update kotlin to 1.8.22; kotlinx.coroutines to 1.7.3 #1007

Merged
merged 3 commits into from
Aug 7, 2023
Merged

chore: update kotlin to 1.8.22; kotlinx.coroutines to 1.7.3 #1007

merged 3 commits into from
Aug 7, 2023

Conversation

aajtodd
Copy link
Collaborator

@aajtodd aajtodd commented Jul 31, 2023

Issue #

N/A

Description of changes

  • Update Kotlin to 1.8.22
  • Update kotlinx.coroutines to 1.7.3

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@aajtodd aajtodd requested a review from a team as a code owner July 31, 2023 18:07
@aajtodd aajtodd mentioned this pull request Jul 31, 2023
Merged
lauzadis
lauzadis approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@lauzadis lauzadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.8.22 is not available internally (latest is 1.8.21). Will that affect internal usage of the SDK?

@aajtodd
Copy link
Collaborator Author

aajtodd commented Aug 3, 2023

@lauzadis

1.8.22 is not available internally (latest is 1.8.21). Will that affect internal usage of the SDK?

Looking at the release notes I don't think so.

@sonarcloud
Copy link

sonarcloud bot commented Aug 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@aajtodd aajtodd merged commit 28d9a48 into main Aug 7, 2023
11 of 13 checks passed
@aajtodd aajtodd deleted the update-deps branch August 7, 2023 20:56
antohaby
antohaby reviewed Jul 2, 2024
View reviewed changes
aws-runtime/build.gradle.kts
@@ -86,28 +86,6 @@ subprojects {
}
}

task<org.jetbrains.kotlin.gradle.testing.internal.KotlinTestReport>("rootAllTest") {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Kotlin Gradle Plugin developer here.
Can you guys confirm that you don't need this code anymore?
We have this bug that we want to close as "Won't Fix". But instead we want to improve UX here.
Would you be so kind sharing your Use Case?

Thanks

Copy link
Member

@lauzadis lauzadis Jul 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for reaching out, the code you are commenting on was deleted in this PR almost 1 year ago, and we never added it back, so it's safe to say we don't need it anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lauzadis lauzadis lauzadis approved these changes

@antohaby antohaby antohaby left review comments

@0marperez 0marperez 0marperez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aajtodd @antohaby @lauzadis @0marperez