Stop using SDK v1 #338
Open
Stop using SDK v1 #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using this library it pulls the AWS SDK v1 because of the dependency declared on STS. But it seems is not actually used. This fixes [issue awslabs#274][1]. [1]: awslabs#274
josepanguera
commented
Mar 11, 2024
Comment on lines
+66
to
+74
| <!-- Because KCL 2.2.9 works on a different protobuf(2.6.1) than KPL's protobuf(3.x)--> | ||
| <!-- excluding this so that KPL's Protobuf version is honored for testing and parsing messages.--> | ||
| <!-- This means we are not yet utilizing the integration of GSR Library with KCL yet. --> | ||
| <exclusions> | ||
| <exclusion> | ||
| <groupId>com.google.protobuf</groupId> | ||
| <artifactId>protobuf-java</artifactId> | ||
| </exclusion> | ||
| </exclusions> |
There was a problem hiding this comment.
I'm not entirely sure this is needed. I copied it from https://github.com/awslabs/aws-glue-schema-registry/blob/master/integration-tests/pom.xml#L85-L93
josepanguera
commented
Mar 11, 2024
Comment on lines
143
to
145
| if (shards.size() > 0) { | ||
| shards.get(shards.size() - 1).getShardId(); | ||
| shards.get(shards.size() - 1).shardId(); | ||
| } |
There was a problem hiding this comment.
These doesn't seem to do anything. I kept it because it was this way originally.
|
Is there any chance this will get merged soon @YangSan0622? I think it will also unblock awslabs/amazon-kinesis-client#1163 |
|
Trying again here, @YangSan0622 or @blacktooth what do you think about merging/releasing this? |
This was referenced Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#274
When using this library it pulls the AWS SDK v1 because of the dependency declared on STS. But it seems is not actually used.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.