Fix jump role manager AWS Organizations API retries #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Why? When multiple accounts are bootstrapped by ADF via changes in the AWS Oranizations hierarchy, the jump-role-manager could run into rate limits of the AWS Organizations API. ## What? This change will ensure that the lambda function will retry more often. While using exponential back-off and jitter as built-in by boto3 and as configured in the Step Function retry logic.
javydekoning
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
When multiple accounts are bootstrapped by ADF via changes in the AWS Organizations hierarchy, the jump-role-manager could run into rate limits of the AWS Organizations API.
What?
This change will ensure that the lambda function will retry more often. While using exponential back-off and jitter as built-in by boto3 and as configured in the Step Function retry logic.
By submitting this pull request, I confirm that you can use, modify, copy, and
redistribute this contribution, under the terms of your choice.