Integration tests addition and refactoring #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added test cases that handles scenarios in a given region: 1/ No databases 2/ One database; no tables 3/ One database ; one table 4/ One database; multiple tables with different naming pattern to test 'LIKE' 5/ Multiple databases; multiple tables in each In those test cases, `getSchemas()`, `getTables()` are tested with different naming schema patterns and table patterns to test 'LIKE'. They also check that `getCatalogs()` return empty result sets. Refactoring: - Refactored existing test suite `DatabaseMetaDataIntegrationTest` to automatically create / delete databases - Refactored `Constants.DATABASES_NAMES` to have clearer database names that indicate they are for integration tests Co-authored-by: RoyZhang2022 <[email protected]> Co-authored-by: RoyZhang2022 <[email protected]> Co-authored-by: RoyZhang2022 <[email protected]>
rajeiyer
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added suggested test cases that handles scenarios in a given region:
1/ No databases
2/ One database; no tables
3/ One database ; one table
4/ One database; multiple tables with different naming pattern to test 'LIKE' 5/ Multiple databases; multiple tables in each
In those test cases,
getSchemas(),getTables()are tested with different naming schema patterns and table patterns to test 'LIKE'. They also check thatgetCatalogs()return empty result sets.Refactoring:
DatabaseMetaDataIntegrationTestto automatically create / delete databasesConstants.DATABASES_NAMESto have clearer database names that indicate they are for integration testsCo-Authored by @RoyZhang2022
Additional Reviewers
@affonsoBQ
@alexey-temnikov
@alinaliBQ
@andiem-bq
@birschick-bq
@mitchell-elholm
@RoyZhang2022