Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump 'ion-js' to 5.2.0 #570

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Bump 'ion-js' to 5.2.0 #570

merged 1 commit into from
Nov 9, 2023

Conversation

trstephen-amazon
Copy link
Contributor

@trstephen-amazon trstephen-amazon commented Nov 9, 2023

This is a 4 -> 5 major version bump for ion-js but presents no breaking changes for the driver. A bit of strangeness around overriding the ion-hash-js dependency on ion-js but it seems necessary because that project has gone dormant and declares a peer dependency on ion-js: "^4.0.0" [code] which would otherwise block this upgrade.

Note that there's also a change to the lockFileVersion of package.json. It bumped 1 -> 3 when I ran npm install 🤷

➜ npm --version
9.8.0

Refs:

  • Docs for package.json overrides

Resolves #428


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This is a 4 -> 5 major version bump but presents no breaking changes for
the driver. A bit of strangeness around overriding the 'ion-hash-js'
dependency on 'ion-js' but it seems necessary because that project has
gone dormant and declares a peer dependency on 'ion-js: "^4.0.0"' which
would otherwise block this upgrade.

Resolves #428
@trstephen-amazon trstephen-amazon marked this pull request as ready for review November 9, 2023 01:06
Copy link
Contributor

@GanyuanTan GanyuanTan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@trstephen-amazon trstephen-amazon merged commit 57d3ac1 into master Nov 9, 2023
11 checks passed
@trstephen-amazon trstephen-amazon deleted the trs/bump-ion branch November 9, 2023 18:49
trstephen-amazon added a commit that referenced this pull request Nov 10, 2023
Incorporates all changes since last release in Nov 2022. This is
exclusively bugfixes.

Notably, #570 bumps the peer dependency of ion-js by a major version and
is the reason the driver is doing a minor (not patch) update.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to ION-JS 5.0
2 participants