Add config to enable PITR #1365
Conversation
| private static final boolean PITR_ENABLED = true; | ||
| private static final Collection<Tag> EMPTY_TAGS = DefaultSdkAutoConstructList.getInstance(); | ||
| private static final Collection<Tag> TAGS = | ||
| Collections.singletonList(Tag.builder().key("foo").value("bar").build()); |
There was a problem hiding this comment.
Thank you for making this more consistent.
| @@ -159,7 +162,7 @@ public DynamoDBLeaseRefresher( | |||
| tableCreatorCallback, | |||
| dynamoDbRequestTimeout, | |||
| BillingMode.PAY_PER_REQUEST, | |||
| false); | |||
| LeaseManagementConfig.DEFAULT_LEASE_TABLE_DELETION_PROTECTION_ENABLED); | |||
There was a problem hiding this comment.
We check that leaseTableDeletionProtectionEnabled() and leaseTablePitrEnabled() equal true, but this will give a false positive if the default changes to true and setLeaseTable...Enabled() methods break.
This is a bit of a nit since it appears this methodology was repeated with other tests. Just including it for consideration.
There was a problem hiding this comment.
Good point, I've added two more tests to set the false value as well
| MultiLangDaemonConfiguration.ResolvedConfiguration resolvedConfiguration = | ||
| configuration.resolvedConfiguration(shardRecordProcessorFactory); | ||
|
|
||
| assertThat(resolvedConfiguration.leaseManagementConfig.leaseTableDeletionProtectionEnabled(), equalTo(true)); |
There was a problem hiding this comment.
minor nit, but this could just be assertTrue(...)
| .pointInTimeRecoverySpecification(PointInTimeRecoverySpecification.builder() | ||
| .pointInTimeRecoveryEnabled(true) | ||
| .build()) |
There was a problem hiding this comment.
Instead of passing in a PointInTimeRecoverySpecification, you can pass in a Consumer<PointInTimeRecoverySpecification.Builder> like so:
| .pointInTimeRecoverySpecification(PointInTimeRecoverySpecification.builder() | |
| .pointInTimeRecoveryEnabled(true) | |
| .build()) | |
| .pointInTimeRecoverySpecification(builder->builder.pointInTimeRecoveryEnabled(true)) |
There was a problem hiding this comment.
Thank you for this shorthand, did not know about it. Updated
Issue #, if available:
Description of changes:
leaseTablePitrEnabledleaseTableDeletionProtectionEnabledandleaseTablePitrEnabledBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.