Generate wrappers from proto files instead of shipping them directly #1340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nakulj
force-pushed
the
proto
branch
3 times, most recently
from
d622679
to
d524c6b
Compare
nakulj
force-pushed
the
proto
branch
2 times, most recently
from
ee4f6d1
to
8493e8a
Compare
This change replaces the generated Messages.java file with the source .proto files. It also includes the pom.xml changes needed to install protoc from Maven Central, and use it to compile the wrapper java code.
brendan-p-lynch
previously approved these changes
Jun 3, 2024
akidambisrinivasan
approved these changes
Jun 3, 2024
nakulj
added a commit
to nakulj/amazon-kinesis-client
that referenced
this pull request
Jun 7, 2024
nakulj
added a commit
that referenced
this pull request
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
.protofile instead of being version controlledBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.