Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify RecordProcessorCheckpointer#advancePosition Metrics usage to ensure proper closure #1224

Conversation

furq-aws
Copy link
Contributor

@furq-aws furq-aws commented Nov 9, 2023

Issue #, if available:
N/A.

Description of changes:
Modify RecordProcessorCheckpointer#advancePosition Metrics usage to ensure proper closure.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@furq-aws furq-aws added the v1.x Issues related to the 1.x version label Nov 9, 2023
@furq-aws furq-aws force-pushed the recordprocessorcheckpointer-advanceposition-close-metric branch from 562a7e6 to 06f47e9 Compare February 23, 2024 01:31
@furq-aws furq-aws marked this pull request as ready for review February 23, 2024 01:39
@furq-aws furq-aws force-pushed the recordprocessorcheckpointer-advanceposition-close-metric branch from 06f47e9 to 7181ccf Compare February 23, 2024 09:19
@furq-aws furq-aws changed the title Close Metrics instance created in RecordProcessorCheckpointer#advancePosition Modify RecordProcessorCheckpointer#advancePosition Metrics usage to ensure proper closure Feb 23, 2024
@furq-aws furq-aws merged commit 48fab1f into awslabs:v1.x Feb 23, 2024
1 check passed
@furq-aws furq-aws deleted the recordprocessorcheckpointer-advanceposition-close-metric branch February 23, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1.x Issues related to the 1.x version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants