EKS logs collector script kube-proxy IPVS information scrape #1795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartermckinnon
approved these changes
Jun 5, 2024
guessi
reviewed
Jun 7, 2024
guessi
reviewed
Jun 7, 2024
| ipvsadm --list --numeric --rate | tee -a "${COLLECT_DIR}"/networking/ipvsadm.txt | ||
| ok -e "\n" | tee -a "${COLLECT_DIR}"/networking/ipvsadm.txt | ||
| ipvsadm --list --numeric --stats --exact | tee -a "${COLLECT_DIR}"/networking/ipvsadm.txt | ||
| ipset --list | tee -a "${COLLECT_DIR}"/networking/ipset.txt |
There was a problem hiding this comment.
Same here, what if there have an old "${COLLECT_DIR}"/networking/ipset.txt existed for a long running node.
There was a problem hiding this comment.
@guessi cannot update tee to overwrite the same file ${COLLECT_DIR}"/networking/ipvsadm.txt here
- can split out ipvsadm current config into separate files, but dont think that is necessary.
- the first tee overwrite above should suffice if there is an existing file
There was a problem hiding this comment.
also there is a cleanup func in the script, that removes the entire {COLLECT_DIR} used for work, I believe
There was a problem hiding this comment.
@cartermckinnon @guessi do I need to replay this change on the latest base branch changes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #1790
Description of changes:
Adding;
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Testing Done
See this guide for recommended testing for PRs. Some tests may not apply. Completing tests and providing additional validation steps are not required, but it is recommended and may reduce review time and time to merge.